Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 223473002: Use premordial Object.isSealed/isFrozen in builtins. (Closed)

Created:
6 years, 8 months ago by Michael Starzinger
Modified:
6 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Use premordial Object.isSealed/isFrozen in builtins. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20477

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Michael Stanton. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M src/array.js View 6 chunks +7 lines, -7 lines 0 comments Download
A test/mjsunit/regress/regress-builtinbust-1.js View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
6 years, 8 months ago (2014-04-03 07:57:30 UTC) #1
mvstanton
nice! DBC below. https://codereview.chromium.org/223473002/diff/1/test/mjsunit/regress/regress-builtinbust-1.js File test/mjsunit/regress/regress-builtinbust-1.js (right): https://codereview.chromium.org/223473002/diff/1/test/mjsunit/regress/regress-builtinbust-1.js#newcode9 test/mjsunit/regress/regress-builtinbust-1.js:9: assertThrows("a.shift()"); I guess here is the ...
6 years, 8 months ago (2014-04-03 08:05:24 UTC) #2
Michael Starzinger
PTAL. https://codereview.chromium.org/223473002/diff/1/test/mjsunit/regress/regress-builtinbust-1.js File test/mjsunit/regress/regress-builtinbust-1.js (right): https://codereview.chromium.org/223473002/diff/1/test/mjsunit/regress/regress-builtinbust-1.js#newcode9 test/mjsunit/regress/regress-builtinbust-1.js:9: assertThrows("a.shift()"); On 2014/04/03 08:05:24, mvstanton wrote: > > ...
6 years, 8 months ago (2014-04-03 08:11:28 UTC) #3
mvstanton
lgtm
6 years, 8 months ago (2014-04-03 08:47:06 UTC) #4
Michael Starzinger
6 years, 8 months ago (2014-04-03 12:23:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20477 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698