Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2234703003: [DevTools] Removed Debugger.canSetScriptSource & Debugger.getBacktrace (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed Debugger.canSetScriptSource & Debugger.getBacktrace BUG=635947 R=dgozman@chromium.org Committed: https://crrev.com/3ecdf6e7c963adf24b15a160f3e7266dcd76a8cf Cr-Commit-Position: refs/heads/master@{#411376}

Patch Set 1 #

Patch Set 2 : a #

Patch Set 3 : fixed test #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -45 lines) Patch
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/updateCallFrameScopes.html View 1 2 2 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version View 1 6 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/js_protocol.json View 1 2 3 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
kozy
Dmitry, please take a look!
4 years, 4 months ago (2016-08-10 22:32:07 UTC) #1
kozy
[DevTools] Removed Debugger.canSetScriptSource & Debugger.getBacktrace
4 years, 4 months ago (2016-08-10 22:35:45 UTC) #2
dgozman
lgtm
4 years, 4 months ago (2016-08-10 22:51:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234703003/20001
4 years, 4 months ago (2016-08-10 23:00:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/275652)
4 years, 4 months ago (2016-08-11 00:52:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234703003/40001
4 years, 4 months ago (2016-08-11 01:14:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/236989) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years, 4 months ago (2016-08-11 01:51:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234703003/60001
4 years, 4 months ago (2016-08-11 16:27:55 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-11 18:13:15 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 18:16:31 UTC) #20
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/3ecdf6e7c963adf24b15a160f3e7266dcd76a8cf
Cr-Commit-Position: refs/heads/master@{#411376}

Powered by Google App Engine
This is Rietveld 408576698