Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2234703002: [turbofan] Remove redundant 'virtual' from store elimination. (Closed)

Created:
4 years, 4 months ago by Jarin
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, bgeron
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove redundant 'virtual' from store elimination. Committed: https://crrev.com/acf0fd3ca1d9c3b9ea47c09cc713ce466af653ee Cr-Commit-Position: refs/heads/master@{#38518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/store-store-elimination.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Jarin
Could you take a look, please?
4 years, 4 months ago (2016-08-10 07:03:30 UTC) #4
Benedikt Meurer
LGTM.
4 years, 4 months ago (2016-08-10 07:15:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234703002/1
4 years, 4 months ago (2016-08-10 07:18:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 07:25:53 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 07:26:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acf0fd3ca1d9c3b9ea47c09cc713ce466af653ee
Cr-Commit-Position: refs/heads/master@{#38518}

Powered by Google App Engine
This is Rietveld 408576698