Deprecate self and total time getters and total sample count getter on CpuProfileNode

include/v8-profiler.h

Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index f2128ce0bed6bb35ebcbdca72cfd6e56d892f892..e642097b1295943e3ae02df8e34a9b4a531dcf8d 100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -61,19 +61,19 @@ class V8_EXPORT CpuProfileNode {
    * Returns total (self + children) execution time of the function,
    * in milliseconds, estimated by samples count.
    */
-  double GetTotalTime() const;
+  V8_DEPRECATED(double GetTotalTime() const);
 
   /**
    * Returns self execution time of the function, in milliseconds,
    * estimated by samples count.
    */
-  double GetSelfTime() const;
+  V8_DEPRECATED(double GetSelfTime() const);
 
   /** Returns the count of samples where function exists. */
-  double GetTotalSamplesCount() const;
+  V8_DEPRECATED(double GetTotalSamplesCount() const);
 
   /** Returns the count of samples where function was currently executing. */
-  double GetSelfSamplesCount() const;
+  unsigned GetSelfSamplesCount() const;

[Sven Panne, 2013/08/08 11:51:57]

Two remarks here:

   * Silently changing the signature of an existing API entry is not really
nice, but I guess that the number of clients of the profiling API is low (i.e. =
1 ;-), so this is OK here. Otherwise I'll redirect complaints from embedders
directly to the CL author... :-D

   * Are we really sure that unsigned is future-proof? Wouldn't uint64_t be
better?

[yurys, 2013/08/08 12:43:49]

Ok, let me do this in two steps as I originally intended: first introduce
unsgined GetHitCount and then deprecate this one.
Internally it is unsigned anyway. With sampling rate 0.1ms it will be enough for
~4 000 000 000 / 10 000 = 400 000 / 3600 ~ 100 hours which is more than enough
for a web application where profiling is regularly done for several minutes. I
can change it if you insist but I don't think there is a need to do this now,
also we would have to change return type of CpuProfile::GetSamplesCount as well.

 
   /** Returns function entry UID. */
   unsigned GetCallUid() const;