Deprecate self and total time getters and total sample count getter on CpuProfileNode

include/v8-profiler.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 43 matching lines @@
   /**
    * Returns the number, 1-based, of the line where the function originates.
    * kNoLineNumberInfo if no line number information is available.
    */
   int GetLineNumber() const;
 
   /**
    * Returns total (self + children) execution time of the function,
    * in milliseconds, estimated by samples count.
    */
-  double GetTotalTime() const;
+  V8_DEPRECATED(double GetTotalTime() const);
 
   /**
    * Returns self execution time of the function, in milliseconds,
    * estimated by samples count.
    */
-  double GetSelfTime() const;
+  V8_DEPRECATED(double GetSelfTime() const);
 
   /** Returns the count of samples where function exists. */
-  double GetTotalSamplesCount() const;
+  V8_DEPRECATED(double GetTotalSamplesCount() const);
 
   /** Returns the count of samples where function was currently executing. */
-  double GetSelfSamplesCount() const;
+  unsigned GetSelfSamplesCount() const;

[Sven Panne, 2013/08/08 11:51:57]

Two remarks here:

   * Silently changing the signature of an existing API entry is not really
nice, but I guess that the number of clients of the profiling API is low (i.e. =
1 ;-), so this is OK here. Otherwise I'll redirect complaints from embedders
directly to the CL author... :-D

   * Are we really sure that unsigned is future-proof? Wouldn't uint64_t be
better?

[yurys, 2013/08/08 12:43:49]

Ok, let me do this in two steps as I originally intended: first introduce
unsgined GetHitCount and then deprecate this one.
Internally it is unsigned anyway. With sampling rate 0.1ms it will be enough for
~4 000 000 000 / 10 000 = 400 000 / 3600 ~ 100 hours which is more than enough
for a web application where profiling is regularly done for several minutes. I
can change it if you insist but I don't think there is a need to do this now,
also we would have to change return type of CpuProfile::GetSamplesCount as well.

 
   /** Returns function entry UID. */
   unsigned GetCallUid() const;
 
   /** Returns id of the node. The id is unique within the tree */
   unsigned GetNodeId() const;
 
   /** Returns child nodes count of the node. */
   int GetChildrenCount() const;
 
@@ skipping 481 matching lines @@
   uint32_t index;  // Index of the time interval that was changed.
   uint32_t count;  // New value of count field for the interval with this index.
   uint32_t size;  // New value of size field for the interval with this index.
 };
 
 
 }  // namespace v8
 
 
 #endif  // V8_V8_PROFILER_H_