Deprecate self and total time getters and total sample count getter on CpuProfileNode

Deprecate self and total time getters and total sample count getter on CpuProfileNode

All of these values are derived from the self samples count and there is no need to evaluate them in v8 when clients can do that when needed on their side.

Also added unsigned GetHitCount() which should be used instead of double GetSelfSamplesCount(). I'm going to deprecate the latter one once Blink has switched to GetHitCount.

BUG=267595
R=loislo@chromium.org, svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16116

[yurys, 2013-08-08 09:28:59]

This change should be landed after Blink r155755 is rolled into Chromium.

[loislo, 2013-08-08 11:04:47]

lgtm

https://codereview.chromium.org/22347003/diff/3001/src/api.cc
File src/api.cc (left):

https://codereview.chromium.org/22347003/diff/3001/src/api.cc#oldcode7481
src/api.cc:7481: IsDeadCheck(isolate, "v8::CpuProfileNode::GetScriptId");
why did you remove that lines?

[Sven Panne, 2013-08-08 11:51:57]

Some DBCs...

https://codereview.chromium.org/22347003/diff/3001/include/v8-profiler.h
File include/v8-profiler.h (right):

https://codereview.chromium.org/22347003/diff/3001/include/v8-profiler.h#newc...
include/v8-profiler.h:76: unsigned GetSelfSamplesCount() const;
Two remarks here:

   * Silently changing the signature of an existing API entry is not really
nice, but I guess that the number of clients of the profiling API is low (i.e. =
1 ;-), so this is OK here. Otherwise I'll redirect complaints from embedders
directly to the CL author... :-D

   * Are we really sure that unsigned is future-proof? Wouldn't uint64_t be
better?

https://codereview.chromium.org/22347003/diff/3001/src/api.cc
File src/api.cc (left):

https://codereview.chromium.org/22347003/diff/3001/src/api.cc#oldcode7481
src/api.cc:7481: IsDeadCheck(isolate, "v8::CpuProfileNode::GetScriptId");
On 2013/08/08 11:04:47, loislo wrote:
> why did you remove that lines?

That's OK, the whole idea of IsDeadCheck is fundamentally broken, anyway, and
it's already on death row...

[yurys, 2013-08-08 12:33:10]

https://codereview.chromium.org/22347003/diff/3001/src/api.cc
File src/api.cc (left):

https://codereview.chromium.org/22347003/diff/3001/src/api.cc#oldcode7481
src/api.cc:7481: IsDeadCheck(isolate, "v8::CpuProfileNode::GetScriptId");
On 2013/08/08 11:04:47, loislo wrote:
> why did you remove that lines?

They make no sense, if v8 is dead then the code should crash on attempt to
retrieve CPU profile.

[yurys, 2013-08-08 12:43:49]

https://codereview.chromium.org/22347003/diff/3001/include/v8-profiler.h
File include/v8-profiler.h (right):

https://codereview.chromium.org/22347003/diff/3001/include/v8-profiler.h#newc...
include/v8-profiler.h:76: unsigned GetSelfSamplesCount() const;
On 2013/08/08 11:51:57, Sven Panne wrote:
> Two remarks here:
> 
>    * Silently changing the signature of an existing API entry is not really
> nice, but I guess that the number of clients of the profiling API is low (i.e.
=
> 1 ;-), so this is OK here. Otherwise I'll redirect complaints from embedders
> directly to the CL author... :-D
> 
Ok, let me do this in two steps as I originally intended: first introduce
unsgined GetHitCount and then deprecate this one.

>    * Are we really sure that unsigned is future-proof? Wouldn't uint64_t be
> better?
Internally it is unsigned anyway. With sampling rate 0.1ms it will be enough for
~4 000 000 000 / 10 000 = 400 000 / 3600 ~ 100 hours which is more than enough
for a web application where profiling is regularly done for several minutes. I
can change it if you insist but I don't think there is a need to do this now,
also we would have to change return type of CpuProfile::GetSamplesCount as well.

[yurys, 2013-08-08 12:51:56]

Added new method with different return type for sample count. Sven, please take
another look.

[Sven Panne, 2013-08-08 13:05:38]

LGTM if there is a strong reason for not using V8_DEPRECATED, otherwise simply
add it.

https://codereview.chromium.org/22347003/diff/10001/include/v8-profiler.h
File include/v8-profiler.h (right):

https://codereview.chromium.org/22347003/diff/10001/include/v8-profiler.h#new...
include/v8-profiler.h:78: double GetSelfSamplesCount() const;
Can't we use V8_DEPRECATED here?

[yurys, 2013-08-08 13:37:41]

https://codereview.chromium.org/22347003/diff/10001/include/v8-profiler.h
File include/v8-profiler.h (right):

https://codereview.chromium.org/22347003/diff/10001/include/v8-profiler.h#new...
include/v8-profiler.h:78: double GetSelfSamplesCount() const;
On 2013/08/08 13:05:38, Sven Panne wrote:
> Can't we use V8_DEPRECATED here?

We need to change Chrome DevTools to use the new GetHitCount first. After that I
will add V8_DEPRECATED here.

[yurys, 2013-08-08 13:40:08]

Committed patchset #3 manually as r16116 (presubmit successful).