Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2234693002: win: Add win_linker_timing setting (Closed)

Created:
4 years, 4 months ago by scottmg
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Add win_linker_timing setting This is useful to see why /incremental is failing when it does. Also tidy up a bit of 2013 logic we don't need any more. Committed: https://crrev.com/ccb02e5b095c62d0a799b40a40f9a7ebebb8298d Cr-Commit-Position: refs/heads/master@{#411082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M build/config/win/BUILD.gn View 3 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
scottmg
4 years, 4 months ago (2016-08-10 04:52:15 UTC) #3
brettw
lgtm
4 years, 4 months ago (2016-08-10 17:11:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234693002/1
4 years, 4 months ago (2016-08-10 17:48:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 17:53:29 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 17:56:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccb02e5b095c62d0a799b40a40f9a7ebebb8298d
Cr-Commit-Position: refs/heads/master@{#411082}

Powered by Google App Engine
This is Rietveld 408576698