Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: recipes/recipe_modules/recipe_autoroller/api.py

Issue 2234633003: recipe_autoroller: back out git cl set-commit changes (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | recipes/recipes/recipe_autoroller.expected/previously_uploaded_match.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipes/recipe_modules/recipe_autoroller/api.py
diff --git a/recipes/recipe_modules/recipe_autoroller/api.py b/recipes/recipe_modules/recipe_autoroller/api.py
index 0464e387ce935d1239767551a58cb9aa751c40b9..efc4895c3beba753a3ed9f1932588cbfdef6675b 100644
--- a/recipes/recipe_modules/recipe_autoroller/api.py
+++ b/recipes/recipe_modules/recipe_autoroller/api.py
@@ -236,11 +236,6 @@ class RecipeAutorollerApi(recipe_api.RecipeApi):
if change_data['diff_digest'] != diff_digest:
need_to_upload = True
rebase = True
- elif roll_result['trivial']:
- # We won't be uploading. Make sure trivial rolls don't get stuck
- # if previous CQ attempt failed because of flake.
- # Pass --rietveld flag to match upload args below.
- self.m.git('cl', 'set-commit', '--rietveld', cwd=workdir)
if need_to_upload:
commit_message = (
« no previous file with comments | « no previous file | recipes/recipes/recipe_autoroller.expected/previously_uploaded_match.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698