Issue 223463003: Fix bug entry and quotation marks in merge-to-branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223463003: Fix bug entry and quotation marks in merge-to-branch. (Closed)

Created:
6 years, 8 months ago by Michael Achenbach

Modified:
6 years, 8 months ago

Reviewers:
Jarin

CC:
v8-dev, Jakob Kummerow

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bug entry and quotation marks in merge-to-branch. This fixes usage of quotation marks inside titles of merged patches. This also fixes aggregation of empty or "none" BUG entries. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20483

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Rebase + review #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
M	tools/push-to-trunk/git_recipes.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/push-to-trunk/merge_to_branch.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jarin

lgtm https://codereview.chromium.org/223463003/diff/20001/tools/push-to-trunk/test_scripts.py File tools/push-to-trunk/test_scripts.py (right): https://codereview.chromium.org/223463003/diff/20001/tools/push-to-trunk/test_scripts.py#newcode1000 tools/push-to-trunk/test_scripts.py:1000: Revert "Somthing" Is not this supposed to be ...

6 years, 8 months ago (2014-04-03 12:31:42 UTC) #2

Michael Achenbach

6 years, 8 months ago (2014-04-03 13:01:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20483 (presubmit successful).

Expand Messages | Collapse Messages