DevTools: DOMStorage should notify the view about storage modifications instead of DOMStorageModel

Source/devtools/front_end/DOMStorageItemsView.js

Index: Source/devtools/front_end/DOMStorageItemsView.js
diff --git a/Source/devtools/front_end/DOMStorageItemsView.js b/Source/devtools/front_end/DOMStorageItemsView.js
index 5d94705b053e1331002de02789d492b814eaae3b..4a1e8a8610dc89941e81ac19c6a241e91bf6e85b 100644
--- a/Source/devtools/front_end/DOMStorageItemsView.js
+++ b/Source/devtools/front_end/DOMStorageItemsView.js
@@ -28,12 +28,11 @@
  * @constructor
  * @extends {WebInspector.View}
  */
-WebInspector.DOMStorageItemsView = function(domStorage, domStorageModel)
+WebInspector.DOMStorageItemsView = function(domStorage)
 {
     WebInspector.View.call(this);
 
     this.domStorage = domStorage;
-    this.domStorageModel = domStorageModel;
 
     this.element.addStyleClass("storage-view");
     this.element.addStyleClass("table");
@@ -45,10 +44,10 @@ WebInspector.DOMStorageItemsView = function(domStorage, domStorageModel)
     this.refreshButton = new WebInspector.StatusBarButton(WebInspector.UIString("Refresh"), "refresh-storage-status-bar-item");
     this.refreshButton.addEventListener("click", this._refreshButtonClicked, this);
 
-    this.domStorageModel.addEventListener(WebInspector.DOMStorageModel.Events.DOMStorageItemsCleared, this._domStorageItemsCleared, this);
-    this.domStorageModel.addEventListener(WebInspector.DOMStorageModel.Events.DOMStorageItemRemoved, this._domStorageItemRemoved, this);
-    this.domStorageModel.addEventListener(WebInspector.DOMStorageModel.Events.DOMStorageItemAdded, this._domStorageItemAdded, this);
-    this.domStorageModel.addEventListener(WebInspector.DOMStorageModel.Events.DOMStorageItemUpdated, this._domStorageItemUpdated, this);
+    this.domStorage.addEventListener(WebInspector.DOMStorage.Events.DOMStorageItemsCleared, this._domStorageItemsCleared, this);
+    this.domStorage.addEventListener(WebInspector.DOMStorage.Events.DOMStorageItemRemoved, this._domStorageItemRemoved, this);
+    this.domStorage.addEventListener(WebInspector.DOMStorage.Events.DOMStorageItemAdded, this._domStorageItemAdded, this);
+    this.domStorage.addEventListener(WebInspector.DOMStorage.Events.DOMStorageItemUpdated, this._domStorageItemUpdated, this);
 }
 
 WebInspector.DOMStorageItemsView.prototype = {
@@ -144,7 +143,7 @@ WebInspector.DOMStorageItemsView.prototype = {
             if (children[i].data.key === storageData.key)
                 return;
 
-        var childNode = new WebInspector.DataGridNode({key: storageData.key, value: storageData.newValue}, false);
+        var childNode = new WebInspector.DataGridNode({key: storageData.key, value: storageData.value}, false);
         rootNode.insertChild(childNode, children.length - 1);
     },
 
@@ -171,8 +170,8 @@ WebInspector.DOMStorageItemsView.prototype = {
                     return;
                 }
                 keyFound = true;
-                if (childNode.data.value !== storageData.newValue) {
-                    childNode.data.value = storageData.newValue;
+                if (childNode.data.value === storageData.oldValue) {

[pfeldman, 2013/08/23 12:17:51]

This changes semantics. Why?

[vivekg__, 2013/08/23 13:19:37]

Oops, this was a stray local change slipped into the patch. Will revert it.
Thanks!

+                    childNode.data.value = storageData.value;
                     childNode.refresh();
                     childNode.select();
                     childNode.reveal();