DevTools: DOMStorage should notify the view about storage modifications instead of DOMStorageModel

Source/devtools/front_end/DOMStorageItemsView.js

 /*
  * Copyright (C) 2008 Nokia Inc.  All rights reserved.
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 10 matching lines @@
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.View}
  */
-WebInspector.DOMStorageItemsView = function(domStorage, domStorageModel)
+WebInspector.DOMStorageItemsView = function(domStorage)
 {
     WebInspector.View.call(this);
 
     this.domStorage = domStorage;
-    this.domStorageModel = domStorageModel;
 
     this.element.addStyleClass("storage-view");
     this.element.addStyleClass("table");
 
     this.deleteButton = new WebInspector.StatusBarButton(WebInspector.UIString("Delete"), "delete-storage-status-bar-item");
     this.deleteButton.visible = false;
     this.deleteButton.addEventListener("click", this._deleteButtonClicked, this);
 
     this.refreshButton = new WebInspector.StatusBarButton(WebInspector.UIString("Refresh"), "refresh-storage-status-bar-item");
     this.refreshButton.addEventListener("click", this._refreshButtonClicked, this);
 
-    this.domStorageModel.addEventListener(WebInspector.DOMStorageModel.Events.DOMStorageItemsCleared, this._domStorageItemsCleared, this);
-    this.domStorageModel.addEventListener(WebInspector.DOMStorageModel.Events.DOMStorageItemRemoved, this._domStorageItemRemoved, this);
-    this.domStorageModel.addEventListener(WebInspector.DOMStorageModel.Events.DOMStorageItemAdded, this._domStorageItemAdded, this);
-    this.domStorageModel.addEventListener(WebInspector.DOMStorageModel.Events.DOMStorageItemUpdated, this._domStorageItemUpdated, this);
+    this.domStorage.addEventListener(WebInspector.DOMStorage.Events.DOMStorageItemsCleared, this._domStorageItemsCleared, this);
+    this.domStorage.addEventListener(WebInspector.DOMStorage.Events.DOMStorageItemRemoved, this._domStorageItemRemoved, this);
+    this.domStorage.addEventListener(WebInspector.DOMStorage.Events.DOMStorageItemAdded, this._domStorageItemAdded, this);
+    this.domStorage.addEventListener(WebInspector.DOMStorage.Events.DOMStorageItemUpdated, this._domStorageItemUpdated, this);
 }
 
 WebInspector.DOMStorageItemsView.prototype = {
     get statusBarItems()
     {
         return [this.refreshButton.element, this.deleteButton.element];
     },
 
     wasShown: function()
     {
@@ skipping 75 matching lines @@
         var rootNode = this._dataGrid.rootNode();
         var children = rootNode.children;
 
         event.consume(true);
         this.deleteButton.visible = true;
 
         for (var i = 0; i < children.length; ++i)
             if (children[i].data.key === storageData.key)
                 return;
 
-        var childNode = new WebInspector.DataGridNode({key: storageData.key, value: storageData.newValue}, false);
+        var childNode = new WebInspector.DataGridNode({key: storageData.key, value: storageData.value}, false);
         rootNode.insertChild(childNode, children.length - 1);
     },
 
     /**
      * @param {WebInspector.Event} event
      */
     _domStorageItemUpdated: function(event)
     {
         if (!this.isShowing() || !this._dataGrid)
             return;
 
         var storageData = event.data;
         var rootNode = this._dataGrid.rootNode();
         var children = rootNode.children;
 
         event.consume(true);
 
         var keyFound = false;
         for (var i = 0; i < children.length; ++i) {
             var childNode = children[i];
             if (childNode.data.key === storageData.key) {
                 if (keyFound) {
                     rootNode.removeChild(childNode);
                     return;
                 }
                 keyFound = true;
-                if (childNode.data.value !== storageData.newValue) {
-                    childNode.data.value = storageData.newValue;
+                if (childNode.data.value === storageData.oldValue) {

[pfeldman, 2013/08/23 12:17:51]

This changes semantics. Why?

[vivekg__, 2013/08/23 13:19:37]

Oops, this was a stray local change slipped into the patch. Will revert it.
Thanks!

+                    childNode.data.value = storageData.value;
                     childNode.refresh();
                     childNode.select();
                     childNode.reveal();
                 }
                 this.deleteButton.visible = true;
             }
         }
     },
 
     _update: function()
@@ skipping 87 matching lines @@
     {
         if (!node || node.isCreationNode)
             return;
 
         if (this.domStorage)
             this.domStorage.removeItem(node.data.key);
     },
 
     __proto__: WebInspector.View.prototype
 }