Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2234573002: arc: Fix logic of selection terms version in OptIn. (Closed)

Created:
4 years, 4 months ago by khmel
Modified:
4 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Fix logic of selection terms version in OptIn. We are not allowed to show ToS in different than Chrome UI language, except the case when we are unable to determine right combination of language and zone and show ToS in default English. This also provides handling of navigator.language in 2 forwats, short and long which can appear in terms. BUG=636178 BUG=b/30434808 TEST=Manually on device, various combinations of time zone, UI languages and VPN. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b4cf059891075dc7f6e45bdc114118c1e5579f46 Cr-Commit-Position: refs/heads/master@{#411077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -13 lines) Patch
M chrome/browser/resources/chromeos/arc_support/playstore.js View 1 chunk +53 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
khmel
Hi Xiyuan, PTAL
4 years, 4 months ago (2016-08-10 00:38:20 UTC) #3
xiyuan
lgtm
4 years, 4 months ago (2016-08-10 16:01:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234573002/1
4 years, 4 months ago (2016-08-10 16:02:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/49545)
4 years, 4 months ago (2016-08-10 16:06:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234573002/1
4 years, 4 months ago (2016-08-10 16:07:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/49551)
4 years, 4 months ago (2016-08-10 16:12:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234573002/1
4 years, 4 months ago (2016-08-10 16:30:57 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 17:47:50 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 17:50:05 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4cf059891075dc7f6e45bdc114118c1e5579f46
Cr-Commit-Position: refs/heads/master@{#411077}

Powered by Google App Engine
This is Rietveld 408576698