Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2234563003: Remove a useless call: Calling lineVec.dot(qPts[0]) (Closed)

Created:
4 years, 4 months ago by jcgregorio
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove a useless call: Calling lineVec.dot(qPts[0]) This is from https://github.com/google/skia/pull/9, an external pull request from https://github.com/sylvestre. BUG=skia: R=bsalomon GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234563003 Committed: https://skia.googlesource.com/skia/+/0be353487c0971475f9d19f2232d3642ea304b10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/gpu/GrPathUtils.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
jcgregorio
4 years, 4 months ago (2016-08-10 15:30:23 UTC) #4
bsalomon
lgtm
4 years, 4 months ago (2016-08-10 17:04:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234563003/1
4 years, 4 months ago (2016-08-11 11:33:54 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 11:43:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0be353487c0971475f9d19f2232d3642ea304b10

Powered by Google App Engine
This is Rietveld 408576698