Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2234513002: Enable promotion of RenderPassDrawQuads to CALayers. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable promotion of RenderPassDrawQuads to CALayers. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/c48bb2ddd6f847130de7956e9bf7e350d875b10c Cr-Commit-Position: refs/heads/master@{#411055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M cc/output/ca_layer_overlay.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/output/ca_layer_overlay.cc View 3 chunks +1 line, -11 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
erikchen
ccameron: Please review.
4 years, 4 months ago (2016-08-09 22:47:28 UTC) #4
ccameron
lgtm
4 years, 4 months ago (2016-08-10 16:45:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234513002/1
4 years, 4 months ago (2016-08-10 16:47:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 16:52:24 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c48bb2ddd6f847130de7956e9bf7e350d875b10c Cr-Commit-Position: refs/heads/master@{#411055}
4 years, 4 months ago (2016-08-10 16:54:54 UTC) #13
erikchen
4 years, 4 months ago (2016-08-12 00:33:28 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2238113002/ by erikchen@chromium.org.

The reason for reverting is: Causes performance regressions when there are a lot
of filters. Probably needs better IOSurface caching.

https://bugs.chromium.org/p/chromium/issues/detail?id=636884.

Powered by Google App Engine
This is Rietveld 408576698