Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2234463002: Switching from keepnames to keepclassmembernames for Parcelable (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switching from keepnames to keepclassmembernames for Parcelable This does not add/remove any classes, methods, or fields. It saves us 25kb in .dex size. BUG=619937 Committed: https://crrev.com/a7f9943a146ddc60427da3d4b74bf9bcbbcfb51f Cr-Commit-Position: refs/heads/master@{#411034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/proguard.flags View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
smaier
4 years, 4 months ago (2016-08-10 13:26:47 UTC) #7
agrieve
free money! lgtm
4 years, 4 months ago (2016-08-10 13:56:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234463002/1
4 years, 4 months ago (2016-08-10 14:00:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 14:04:00 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a7f9943a146ddc60427da3d4b74bf9bcbbcfb51f Cr-Commit-Position: refs/heads/master@{#411034}
4 years, 4 months ago (2016-08-10 14:05:53 UTC) #14
smaier
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2240443002/ by smaier@chromium.org. ...
4 years, 4 months ago (2016-08-11 13:26:11 UTC) #15
pkotwicz
4 years, 4 months ago (2016-08-11 13:57:12 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2234423002/ by pkotwicz@chromium.org.

The reason for reverting is: Crashes on startup.

Powered by Google App Engine
This is Rietveld 408576698