device/usb/mojo/device_manager_impl.h - Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/mojo/device_manager_impl.h

Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the vector converter into a private header. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/usb/mojo/device_manager_impl.h

diff --git a/device/usb/mojo/device_manager_impl.h b/device/usb/mojo/device_manager_impl.h

index 87b79d883a0647a10d712bc9ce4a6c1133b66e24..bf7a893d647d9b961b2df7ac057bc173c3f9b5bf 100644

--- a/device/usb/mojo/device_manager_impl.h

+++ b/device/usb/mojo/device_manager_impl.h

@@ -54,7 +54,7 @@ class DeviceManagerImpl : public DeviceManager, public UsbService::Observer {

// DeviceManager implementation:

void GetDevices(EnumerationOptionsPtr options,

const GetDevicesCallback& callback) override;

- void GetDevice(const mojo::String& guid,

+ void GetDevice(const std::string& guid,

mojo::InterfaceRequest<Device> device_request) override;

void SetClient(DeviceManagerClientPtr client) override;

« no previous file with comments | « device/usb/mojo/device_impl_unittest.cc ('k') | device/usb/mojo/device_manager_impl.cc » ('j') | device/usb/mojo/type_converters.h » ('J')