Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: device/usb/mojo/device_impl.h

Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move the vector converter into a private header. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/usb/mojo/device_impl.h
diff --git a/device/usb/mojo/device_impl.h b/device/usb/mojo/device_impl.h
index 38a03ce4bced4ea222b85d0cdb36b7b3cfecbf37..8ec722a478b916fde68a75f75358deedd2c305bc 100644
--- a/device/usb/mojo/device_impl.h
+++ b/device/usb/mojo/device_impl.h
@@ -6,6 +6,7 @@
#define DEVICE_USB_MOJO_DEVICE_IMPL_H_
#include <stdint.h>
+#include <vector>
#include "base/callback_forward.h"
#include "base/macros.h"
@@ -74,7 +75,7 @@ class DeviceImpl : public Device, public device::UsbDevice::Observer {
uint32_t timeout,
const ControlTransferInCallback& callback) override;
void ControlTransferOut(ControlTransferParamsPtr params,
- mojo::Array<uint8_t> data,
+ const std::vector<uint8_t>& data,
uint32_t timeout,
const ControlTransferOutCallback& callback) override;
void GenericTransferIn(uint8_t endpoint_number,
@@ -82,18 +83,18 @@ class DeviceImpl : public Device, public device::UsbDevice::Observer {
uint32_t timeout,
const GenericTransferInCallback& callback) override;
void GenericTransferOut(uint8_t endpoint_number,
- mojo::Array<uint8_t> data,
+ const std::vector<uint8_t>& data,
uint32_t timeout,
const GenericTransferOutCallback& callback) override;
void IsochronousTransferIn(
uint8_t endpoint_number,
- mojo::Array<uint32_t> packet_lengths,
+ const std::vector<uint32_t>& packet_lengths,
uint32_t timeout,
const IsochronousTransferInCallback& callback) override;
void IsochronousTransferOut(
uint8_t endpoint_number,
- mojo::Array<uint8_t> data,
- mojo::Array<uint32_t> packet_lengths,
+ const std::vector<uint8_t>& data,
+ const std::vector<uint32_t>& packet_lengths,
uint32_t timeout,
const IsochronousTransferOutCallback& callback) override;

Powered by Google App Engine
This is Rietveld 408576698