chrome/browser/usb/web_usb_chooser_service.h - Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/usb/web_usb_chooser_service.h

Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the vector converter into a private header. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/usb_chooser_dialog_android.cc ('k') | chrome/browser/usb/web_usb_chooser_service.cc » ('j') | device/usb/mojo/type_converters.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/usb/web_usb_chooser_service.h

diff --git a/chrome/browser/usb/web_usb_chooser_service.h b/chrome/browser/usb/web_usb_chooser_service.h

index e0cffe526697ee3e674cfc60ca51fd14468a881c..8b5be76b75ce02004c01360a79c2d470dc97685f 100644

--- a/chrome/browser/usb/web_usb_chooser_service.h

+++ b/chrome/browser/usb/web_usb_chooser_service.h

@@ -10,7 +10,6 @@

#include "base/macros.h"

#include "components/bubble/bubble_reference.h"

#include "device/usb/public/interfaces/chooser_service.mojom.h"

-#include "mojo/public/cpp/bindings/array.h"

#include "mojo/public/cpp/bindings/binding_set.h"

#include "mojo/public/cpp/bindings/interface_request.h"

@@ -32,7 +31,7 @@ class WebUsbChooserService : public device::usb::ChooserService {

~WebUsbChooserService() override;

// device::usb::ChooserService:

- void GetPermission(mojo::Array<device::usb::DeviceFilterPtr> device_filters,

+ void GetPermission(std::vector<device::usb::DeviceFilterPtr> device_filters,

const GetPermissionCallback& callback) override;

void Bind(mojo::InterfaceRequest<device::usb::ChooserService> request);