chrome/browser/android/usb/web_usb_chooser_service_android.cc - Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/usb/web_usb_chooser_service_android.cc

Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the vector converter into a private header. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/usb/web_usb_chooser_service_android.h ('k') | chrome/browser/ui/android/usb_chooser_dialog_android.h » ('j') | device/usb/mojo/type_converters.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/usb/web_usb_chooser_service_android.cc

diff --git a/chrome/browser/android/usb/web_usb_chooser_service_android.cc b/chrome/browser/android/usb/web_usb_chooser_service_android.cc

index 2aa194494d38615a97623c66bd41666675e4e8e1..5443d55654142258bb9d3b1c908e5b471e299640 100644

--- a/chrome/browser/android/usb/web_usb_chooser_service_android.cc

+++ b/chrome/browser/android/usb/web_usb_chooser_service_android.cc

@@ -20,7 +20,7 @@ WebUsbChooserServiceAndroid::WebUsbChooserServiceAndroid(

WebUsbChooserServiceAndroid::~WebUsbChooserServiceAndroid() {}

void WebUsbChooserServiceAndroid::GetPermission(

- mojo::Array<device::usb::DeviceFilterPtr> device_filters,

+ std::vector<device::usb::DeviceFilterPtr> device_filters,

const GetPermissionCallback& callback) {

usb_chooser_dialog_android_.push_back(

base::WrapUnique(new UsbChooserDialogAndroid(