Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: device/usb/mojo/device_manager_impl.cc

Issue 2234443002: Mojo C++ binding: make device/usb mojom targets use STD string/vector types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move the vector converter into a private header. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/usb/mojo/device_manager_impl.h" 5 #include "device/usb/mojo/device_manager_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
11 11
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "device/core/device_client.h" 13 #include "device/core/device_client.h"
14 #include "device/usb/mojo/device_impl.h" 14 #include "device/usb/mojo/device_impl.h"
15 #include "device/usb/mojo/permission_provider.h" 15 #include "device/usb/mojo/permission_provider.h"
16 #include "device/usb/mojo/type_converters.h" 16 #include "device/usb/mojo/type_converters.h"
17 #include "device/usb/public/interfaces/device.mojom.h" 17 #include "device/usb/public/interfaces/device.mojom.h"
18 #include "device/usb/usb_device.h" 18 #include "device/usb/usb_device.h"
19 #include "device/usb/usb_device_filter.h" 19 #include "device/usb/usb_device_filter.h"
20 #include "device/usb/usb_service.h" 20 #include "device/usb/usb_service.h"
21 #include "mojo/common/common_type_converters.h"
21 #include "mojo/public/cpp/bindings/array.h" 22 #include "mojo/public/cpp/bindings/array.h"
22 #include "mojo/public/cpp/bindings/interface_request.h" 23 #include "mojo/public/cpp/bindings/interface_request.h"
23 24
24 namespace device { 25 namespace device {
25 namespace usb { 26 namespace usb {
26 27
27 // static 28 // static
28 void DeviceManagerImpl::Create( 29 void DeviceManagerImpl::Create(
29 base::WeakPtr<PermissionProvider> permission_provider, 30 base::WeakPtr<PermissionProvider> permission_provider,
30 mojo::InterfaceRequest<DeviceManager> request) { 31 mojo::InterfaceRequest<DeviceManager> request) {
(...skipping 25 matching lines...) Expand all
56 } 57 }
57 58
58 void DeviceManagerImpl::GetDevices(EnumerationOptionsPtr options, 59 void DeviceManagerImpl::GetDevices(EnumerationOptionsPtr options,
59 const GetDevicesCallback& callback) { 60 const GetDevicesCallback& callback) {
60 usb_service_->GetDevices(base::Bind(&DeviceManagerImpl::OnGetDevices, 61 usb_service_->GetDevices(base::Bind(&DeviceManagerImpl::OnGetDevices,
61 weak_factory_.GetWeakPtr(), 62 weak_factory_.GetWeakPtr(),
62 base::Passed(&options), callback)); 63 base::Passed(&options), callback));
63 } 64 }
64 65
65 void DeviceManagerImpl::GetDevice( 66 void DeviceManagerImpl::GetDevice(
66 const mojo::String& guid, 67 const std::string& guid,
67 mojo::InterfaceRequest<Device> device_request) { 68 mojo::InterfaceRequest<Device> device_request) {
68 scoped_refptr<UsbDevice> device = usb_service_->GetDevice(guid); 69 scoped_refptr<UsbDevice> device = usb_service_->GetDevice(guid);
69 if (!device) 70 if (!device)
70 return; 71 return;
71 72
72 if (permission_provider_ && 73 if (permission_provider_ &&
73 permission_provider_->HasDevicePermission(device)) { 74 permission_provider_->HasDevicePermission(device)) {
74 new DeviceImpl(device, DeviceInfo::From(*device), permission_provider_, 75 new DeviceImpl(device, DeviceInfo::From(*device), permission_provider_,
75 std::move(device_request)); 76 std::move(device_request));
76 } 77 }
77 } 78 }
78 79
79 void DeviceManagerImpl::SetClient(DeviceManagerClientPtr client) { 80 void DeviceManagerImpl::SetClient(DeviceManagerClientPtr client) {
80 client_ = std::move(client); 81 client_ = std::move(client);
81 } 82 }
82 83
83 void DeviceManagerImpl::OnGetDevices( 84 void DeviceManagerImpl::OnGetDevices(
84 EnumerationOptionsPtr options, 85 EnumerationOptionsPtr options,
85 const GetDevicesCallback& callback, 86 const GetDevicesCallback& callback,
86 const std::vector<scoped_refptr<UsbDevice>>& devices) { 87 const std::vector<scoped_refptr<UsbDevice>>& devices) {
87 std::vector<UsbDeviceFilter> filters; 88 std::vector<UsbDeviceFilter> filters;
88 if (options) 89 if (options && options->filters)
89 filters = options->filters.To<std::vector<UsbDeviceFilter>>(); 90 filters = mojo::ConvertTo<std::vector<UsbDeviceFilter>>(*options->filters);
90 91
91 mojo::Array<DeviceInfoPtr> device_infos; 92 std::vector<DeviceInfoPtr> device_infos;
92 for (const auto& device : devices) { 93 for (const auto& device : devices) {
93 if (filters.empty() || UsbDeviceFilter::MatchesAny(device, filters)) { 94 if (filters.empty() || UsbDeviceFilter::MatchesAny(device, filters)) {
94 if (permission_provider_ && 95 if (permission_provider_ &&
95 permission_provider_->HasDevicePermission(device)) { 96 permission_provider_->HasDevicePermission(device)) {
96 device_infos.push_back(DeviceInfo::From(*device)); 97 device_infos.push_back(DeviceInfo::From(*device));
97 } 98 }
98 } 99 }
99 } 100 }
100 101
101 callback.Run(std::move(device_infos)); 102 callback.Run(std::move(device_infos));
(...skipping 10 matching lines...) Expand all
112 permission_provider_->HasDevicePermission(device)) 113 permission_provider_->HasDevicePermission(device))
113 client_->OnDeviceRemoved(DeviceInfo::From(*device)); 114 client_->OnDeviceRemoved(DeviceInfo::From(*device));
114 } 115 }
115 116
116 void DeviceManagerImpl::WillDestroyUsbService() { 117 void DeviceManagerImpl::WillDestroyUsbService() {
117 delete this; 118 delete this;
118 } 119 }
119 120
120 } // namespace usb 121 } // namespace usb
121 } // namespace device 122 } // namespace device
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698