Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 2234433002: [MD settings] button container to list button in site settings (Closed)

Created:
4 years, 4 months ago by dschuyler
Modified:
4 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] button container to list button in site settings This CL fixes an issue with the add site row button not being tall enough. The fix changes it from a paper-button to use a .list-button class instead (which is how it's done elsewhere in md-settings). BUG=636081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/46f26b6a2cd85f8ccf1fc08c2194562d6eb1d538 Cr-Commit-Position: refs/heads/master@{#411227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M chrome/browser/resources/settings/site_settings/site_list.html View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 4 months ago (2016-08-09 20:49:56 UTC) #5
tommycli
lgtm - this is fine if we use this list-button in other places of settings. ...
4 years, 4 months ago (2016-08-10 17:29:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234433002/1
4 years, 4 months ago (2016-08-11 00:32:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 02:19:39 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 02:22:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46f26b6a2cd85f8ccf1fc08c2194562d6eb1d538
Cr-Commit-Position: refs/heads/master@{#411227}

Powered by Google App Engine
This is Rietveld 408576698