[Reland] Web Animations: Introduce String based KeyframeEffectModel

[Reland] Web Animations: Introduce String based KeyframeEffectModel

Note: This is a rework of issue 212023004

This patch refactors KeyframeEffectModel to support different types of
keyframe values. The common keyframe logic is retained in
KeyframeEffectModelBase to be inherited by the keyframe type specialisations.

KeyframeEffectModel is then templated on Keyframe type, with a hierarchy of Keyframes
including StringKeyframe and AnimatableValueKeyframe being introduced.

String based keyframes are being introduced to properly support the JS API
for Web Animations element.animate().

Original issue: https://codereview.chromium.org/215883005

Please note that this version includes the Oilpan changes made in
https://codereview.chromium.org/222893005/

TBR=dstockwell

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170768

[dstockwell, 2014-04-03 10:39:38]

lgtm

[commit-bot: I haz the power, 2014-04-03 10:39:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shans@chromium.org/223443002/20001

[commit-bot: I haz the power, 2014-04-03 11:50:50]

Change committed as 170768

[haraken, 2014-04-03 12:43:37]

This CL again broke oilpan builds (I'll fix shortly). I'm not intending to ask
you to spend time in taking care of oilpan things, but I'd be happy if you could
just cc oilpan-reviews@chromium.org when making a change related to oilpan.
Thanks!

[shans_google.com, 2014-04-03 21:23:58]

Hi Haraken,

We can do that.

Out of interest, was this only an oilpan-related change because I
incorporated your previous fix: https://codereview.chromium.org/222893005/?
Otherwise, what are some basic guidelines we can use when determining if a
change is oilpan-related?

Thanks,
     -Shane


On Thu, Apr 3, 2014 at 11:43 PM, <haraken@chromium.org> wrote:

> This CL again broke oilpan builds (I'll fix shortly). I'm not intending to
> ask
> you to spend time in taking care of oilpan things, but I'd be happy if you
> could
> just cc oilpan-reviews@chromium.org when making a change related to
> oilpan.
> Thanks!
>
>
> https://codereview.chromium.org/223443002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.