components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h - Issue 2234393002: Marking last_visited date for bookmarks created from an open tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

Issue 2234393002: Marking last_visited date for bookmarks created from an open tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Marc's comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ntp_snippets/bookmark_last_visit_updater.cc ('k') | components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

diff --git a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

index 36ff7db1177532b10786341900df29872ae984fa..bbea0bdb3eff360902e6a8f657ebed4f840be146 100644

--- a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

+++ b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

@@ -27,8 +27,8 @@ void UpdateBookmarkOnURLVisitedInMainFrame(

bookmarks::BookmarkModel* bookmark_model,

const GURL& url);

-// Gets the last visit date for a given bookmark |node|. If the bookmark lacks

-// this info, it returns it creation date.

+// Gets the last visit date for a given bookmark |node|. The visit when the

+// bookmark is created also counts.

base::Time GetLastVisitDateForBookmark(const bookmarks::BookmarkNode* node);

// Marks all bookmarks with the given URL as dismissed.