Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/ntp_snippets/bookmark_last_visit_updater.h

Issue 2234393002: Marking last_visited date for bookmarks created from an open tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Marc's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ntp_snippets/bookmark_last_visit_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ntp_snippets/bookmark_last_visit_updater.h
diff --git a/chrome/browser/ntp_snippets/bookmark_last_visit_updater.h b/chrome/browser/ntp_snippets/bookmark_last_visit_updater.h
index ff9aa9bea520b87762a6e25acb227034ee62795d..38422fb69e5ddea53a24a92c72cd5c37e56392fa 100644
--- a/chrome/browser/ntp_snippets/bookmark_last_visit_updater.h
+++ b/chrome/browser/ntp_snippets/bookmark_last_visit_updater.h
@@ -6,13 +6,16 @@
#define CHROME_BROWSER_NTP_SNIPPETS_BOOKMARK_LAST_VISIT_UPDATER_H_
#include <memory>
+#include <set>
#include "base/macros.h"
+#include "components/bookmarks/browser/bookmark_model_observer.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
namespace bookmarks {
class BookmarkModel;
+class BookmarkNode;
} // namespace bookmarks
namespace content {
@@ -24,7 +27,8 @@ class WebContents;
// generic function ntp_snippets::UpdateBookmarkOnURLVisitedInMainFrame().
class BookmarkLastVisitUpdater
: public content::WebContentsObserver,
- public content::WebContentsUserData<BookmarkLastVisitUpdater> {
+ public content::WebContentsUserData<BookmarkLastVisitUpdater>,
+ public bookmarks::BookmarkModelObserver {
public:
~BookmarkLastVisitUpdater() override;
@@ -38,11 +42,45 @@ class BookmarkLastVisitUpdater
BookmarkLastVisitUpdater(content::WebContents* web_contents,
bookmarks::BookmarkModel* bookmark_model);
+ // Overridden from BookmarkModelObserver:
+ void BookmarkModelLoaded(bookmarks::BookmarkModel* model,
+ bool ids_reassigned) override {}
+ void BookmarkNodeMoved(bookmarks::BookmarkModel* model,
+ const bookmarks::BookmarkNode* old_parent,
+ int old_index,
+ const bookmarks::BookmarkNode* new_parent,
+ int new_index) override {}
+ void BookmarkNodeAdded(bookmarks::BookmarkModel* model,
+ const bookmarks::BookmarkNode* parent,
+ int index) override;
+ void BookmarkNodeRemoved(
+ bookmarks::BookmarkModel* model,
+ const bookmarks::BookmarkNode* parent,
+ int old_index,
+ const bookmarks::BookmarkNode* node,
+ const std::set<GURL>& no_longer_bookmarked) override {}
+ void BookmarkNodeChanged(bookmarks::BookmarkModel* model,
+ const bookmarks::BookmarkNode* node) override {}
+ void BookmarkNodeChildrenReordered(
+ bookmarks::BookmarkModel* model,
+ const bookmarks::BookmarkNode* node) override {}
+ void BookmarkAllUserNodesRemoved(
+ bookmarks::BookmarkModel* model,
+ const std::set<GURL>& removed_urls) override {}
+ void BookmarkNodeFaviconChanged(
+ bookmarks::BookmarkModel* model,
+ const bookmarks::BookmarkNode* node) override {}
+
// Overridden from content::WebContentsObserver:
void DidStartNavigation(
content::NavigationHandle* navigation_handle) override;
+ void DidRedirectNavigation(
+ content::NavigationHandle* navigation_handle) override;
+
+ void NewURLVisited(content::NavigationHandle* navigation_handle);
bookmarks::BookmarkModel* bookmark_model_;
+ content::WebContents* web_contents_;
DISALLOW_COPY_AND_ASSIGN(BookmarkLastVisitUpdater);
};
« no previous file with comments | « no previous file | chrome/browser/ntp_snippets/bookmark_last_visit_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698