Marking last_visited date for bookmarks created from an open tab

chrome/browser/ntp_snippets/bookmark_last_visit_updater.h

Index: chrome/browser/ntp_snippets/bookmark_last_visit_updater.h
diff --git a/chrome/browser/ntp_snippets/bookmark_last_visit_updater.h b/chrome/browser/ntp_snippets/bookmark_last_visit_updater.h
index ff9aa9bea520b87762a6e25acb227034ee62795d..a3aa594f02fdccaa738d08cd553d870f565cc7b0 100644
--- a/chrome/browser/ntp_snippets/bookmark_last_visit_updater.h
+++ b/chrome/browser/ntp_snippets/bookmark_last_visit_updater.h
@@ -6,13 +6,16 @@
 #define CHROME_BROWSER_NTP_SNIPPETS_BOOKMARK_LAST_VISIT_UPDATER_H_
 
 #include <memory>
+#include <set>
 
 #include "base/macros.h"
+#include "components/bookmarks/browser/bookmark_model_observer.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 
 namespace bookmarks {
 class BookmarkModel;
+class BookmarkNode;
 }  // namespace bookmarks
 
 namespace content {
@@ -24,7 +27,8 @@ class WebContents;
 // generic function ntp_snippets::UpdateBookmarkOnURLVisitedInMainFrame().
 class BookmarkLastVisitUpdater
     : public content::WebContentsObserver,
-      public content::WebContentsUserData<BookmarkLastVisitUpdater> {
+      public content::WebContentsUserData<BookmarkLastVisitUpdater>,
+      public bookmarks::BookmarkModelObserver {
  public:
   ~BookmarkLastVisitUpdater() override;
 
@@ -32,6 +36,35 @@ class BookmarkLastVisitUpdater
       content::WebContents* web_contents,
       bookmarks::BookmarkModel* bookmark_model);
 
+  // BookmarkModelObserver overrides

[Marc Treib, 2016/08/11 13:03:43]

All these can be private.
Also, nit: Choose a consistent style for this comment and the corresponding one
for WebContentsObserver

[jkrcal, 2016/08/11 13:59:27]

Done.

+  void BookmarkModelLoaded(bookmarks::BookmarkModel* model,
+                           bool ids_reassigned) override {}
+  void BookmarkNodeMoved(bookmarks::BookmarkModel* model,
+                         const bookmarks::BookmarkNode* old_parent,
+                         int old_index,
+                         const bookmarks::BookmarkNode* new_parent,
+                         int new_index) override {}
+  void BookmarkNodeAdded(bookmarks::BookmarkModel* model,
+                         const bookmarks::BookmarkNode* parent,
+                         int index) override;
+  void BookmarkNodeRemoved(
+      bookmarks::BookmarkModel* model,
+      const bookmarks::BookmarkNode* parent,
+      int old_index,
+      const bookmarks::BookmarkNode* node,
+      const std::set<GURL>& no_longer_bookmarked) override {}
+  void BookmarkNodeChanged(bookmarks::BookmarkModel* model,
+                           const bookmarks::BookmarkNode* node) override {}
+  void BookmarkNodeChildrenReordered(
+      bookmarks::BookmarkModel* model,
+      const bookmarks::BookmarkNode* node) override {}
+  void BookmarkAllUserNodesRemoved(
+      bookmarks::BookmarkModel* model,
+      const std::set<GURL>& removed_urls) override {}
+  void BookmarkNodeFaviconChanged(
+      bookmarks::BookmarkModel* model,
+      const bookmarks::BookmarkNode* node) override {}
+
  private:
   friend class content::WebContentsUserData<BookmarkLastVisitUpdater>;
 
@@ -41,8 +74,15 @@ class BookmarkLastVisitUpdater
   // Overridden from content::WebContentsObserver:
   void DidStartNavigation(
       content::NavigationHandle* navigation_handle) override;
+  void DidRedirectNavigation(
+      content::NavigationHandle* navigation_handle) override;
+
+  void NewURLVisited(content::NavigationHandle* navigation_handle);
 
   bookmarks::BookmarkModel* bookmark_model_;
+  content::WebContents* web_contents_;
+
+  GURL current_navigation_url_;

[Marc Treib, 2016/08/11 13:03:43]

Unused?

[jkrcal, 2016/08/11 13:59:27]

Sorry, a left-over from previous implementation version.

 
   DISALLOW_COPY_AND_ASSIGN(BookmarkLastVisitUpdater);
 };