Marking last_visited date for bookmarks created from an open tab

components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h"
 
 #include <algorithm>
 #include <string>
 #include <utility>
 
@@ skipping 43 matching lines @@
   for (const BookmarkNode* node : bookmarks_for_url)
     bookmark_model->SetNodeMetaInfo(node, kBookmarkLastVisitDateKey, now);
 }
 
 base::Time GetLastVisitDateForBookmark(const BookmarkNode* node) {
   if (!node)
     return base::Time::UnixEpoch();
 
   std::string last_visit_date_string;
   node->GetMetaInfo(kBookmarkLastVisitDateKey, &last_visit_date_string);
-
-  // Use creation date if no last visit info present.

[Marc Treib, 2016/08/11 13:03:43]

I think the header has a comment that mentions the fallback - does that need to
be updated?

[jkrcal, 2016/08/11 13:59:26]

Done.

-  if (last_visit_date_string.empty())
-    return node->date_added();
-
   return ParseLastVisitDate(last_visit_date_string);
 }
 
 void MarkBookmarksDismissed(BookmarkModel* bookmark_model, const GURL& url) {
   std::vector<const BookmarkNode*> nodes;
   bookmark_model->GetNodesByURL(url, &nodes);
   for (const BookmarkNode* node : nodes)
     bookmark_model->SetNodeMetaInfo(node, kBookmarkDismissedFromNTP, "1");
 }
 
@@ skipping 100 matching lines @@
   // Insert into |result|.
   std::vector<const BookmarkNode*> result;
   for (const BookmarkModel::URLAndTitle& bookmark : bookmarks) {
     result.push_back(
         bookmark_model->GetMostRecentlyAddedUserNodeForURL(bookmark.url));
   }
   return result;
 }
 
 }  // namespace ntp_snippets