Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: go/src/infra/appengine/test-results/frontend/get.go

Issue 2234353002: test-results: package model: Add full_result.go and tests (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Improve coverage Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | go/src/infra/appengine/test-results/model/aggregate_result.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/appengine/test-results/frontend/get.go
diff --git a/go/src/infra/appengine/test-results/frontend/get.go b/go/src/infra/appengine/test-results/frontend/get.go
index 4126c789432164638bd1b28295b046f23e3ef1ad..6e0ed6ba694846c38142978a265c526376abee5a 100644
--- a/go/src/infra/appengine/test-results/frontend/get.go
+++ b/go/src/infra/appengine/test-results/frontend/get.go
@@ -209,10 +209,16 @@ func respondTestFileDefault(ctx *router.Context, params URLParams) {
finalData := tf.Data
if params.TestListJSON {
+ data, err := model.CleanJSON(tf.Data)
+ if err != nil {
+ http.Error(w, err.Error(), http.StatusInternalServerError)
+ logging.Errorf(c, "failed to clean test results JSON: %v", err)
+ return
+ }
aggr := model.AggregateResult{Builder: params.Builder}
- if err := json.NewDecoder(tf.Data).Decode(&aggr); err != nil {
+ if err := json.NewDecoder(data).Decode(&aggr); err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
- logging.Errorf(c, "failed to unmarshal TestResults JSON: %+v: %v", tf.Data, err)
+ logging.Errorf(c, "failed to unmarshal test results JSON: %+v: %v", data, err)
return
}
aggr.Tests.ToTestList()
« no previous file with comments | « no previous file | go/src/infra/appengine/test-results/model/aggregate_result.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698