Fix zero_termination tests in the bots (fixes #27066)

Fix zero_termination tests in the bots.

This test only fails in the bots because they don't build the SDK, they use a prebuilt SDK. The script called sdk/bin/dart2js which assumes you have a binary under out/ReleaseX64/dart.

R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/2c7f73735397e8a199098f878f2038df8d6b9142

[Siggi Cherem (dart-lang), 2016-08-12 17:32:25]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2016-08-12 17:34:07]

Description was changed from

==========
Add reason to debug failures seen in the bots.

Our unit-test bots show a failure on this test, but I haven't been able to repro
it locally, so I'm adding some extra data to see if we can debug it remotely.
==========

to

==========
Fix zero_termination tests in the bots.

This test only fails in the bots because they don't build the SDK, they use a
prebuilt SDK. The script called sdk/bin/dart2js which assumes you have a binary
under out/ReleaseX64/dart.
==========

[Siggi Cherem (dart-lang), 2016-08-12 17:34:34]

sigmund@google.com changed reviewers:
+ sra@google.com, whesse@google.com

[sra1, 2016-08-12 17:51:58]

lgtm

[Siggi Cherem (dart-lang), 2016-08-12 17:54:01]

Description was changed from

==========
Fix zero_termination tests in the bots.

This test only fails in the bots because they don't build the SDK, they use a
prebuilt SDK. The script called sdk/bin/dart2js which assumes you have a binary
under out/ReleaseX64/dart.
==========

to

==========
Fix zero_termination tests in the bots.

This test only fails in the bots because they don't build the SDK, they use a
prebuilt SDK. The script called sdk/bin/dart2js which assumes you have a binary
under out/ReleaseX64/dart.

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2c7f73735397e8a199098f878f2038df8d6b9142
==========

[Siggi Cherem (dart-lang), 2016-08-12 17:54:02]

Committed patchset #1 (id:20001) manually as
2c7f73735397e8a199098f878f2038df8d6b9142 (presubmit successful).

[Bill Hesse, 2016-08-12 19:01:31]

LGTM, but think about the comments.

https://codereview.chromium.org/2234343004/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/zero_termination_test.dart (right):

https://codereview.chromium.org/2234343004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/zero_termination_test.dart:52: String dart2jsPath =
path.normalize(
Maybe check if this exists, and don't fail if it is missing?

But I'm happy with changing tests so they only work when run from an SDK, not
from executables and scripts all over the checkout.

https://codereview.chromium.org/2234343004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/zero_termination_test.dart:55: List allArgs =
['--package-root=${Platform.packageRoot}',
I'm just working on removing packageRoot from test scripts today.  These will
soon be run with a package spec file, not a package root.

[Siggi Cherem (dart-lang), 2016-08-12 20:21:14]

https://codereview.chromium.org/2234343004/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/zero_termination_test.dart (right):

https://codereview.chromium.org/2234343004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/zero_termination_test.dart:52: String dart2jsPath =
path.normalize(
On 2016/08/12 19:01:31, Bill Hesse wrote:
> Maybe check if this exists, and don't fail if it is missing?
> 
> But I'm happy with changing tests so they only work when run from an SDK, not
> from executables and scripts all over the checkout.

I'd be afraid that the test would be "passing" but not running in that case.

https://codereview.chromium.org/2234343004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/zero_termination_test.dart:55: List allArgs =
['--package-root=${Platform.packageRoot}',
On 2016/08/12 19:01:31, Bill Hesse wrote:
> I'm just working on removing packageRoot from test scripts today.  These will
> soon be run with a package spec file, not a package root.

good point - we should fix it to pass along whichever was specified in the first
place.