fix #620, infer the input files from sources

test/codegen_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Tests code generation.
 ///
 /// Runs Dart Dev Compiler on all input in the `codegen` directory and checks
 /// that the output is what we expected.
 library dev_compiler.test.codegen_test;
 
 // TODO(rnystrom): This doesn't actually run any tests any more. It just
 // compiles stuff. This should be changed to not use unittest and just be a
 // regular program that outputs files.
 
 import 'dart:convert' show JSON;
 import 'dart:io' show Directory, File, Platform;
 import 'package:args/args.dart' show ArgParser, ArgResults;
 import 'package:path/path.dart' as path;
-import 'package:test/test.dart' show group, test;
+import 'package:test/test.dart' show test;
 
 import 'package:analyzer/analyzer.dart'
     show
         ExportDirective,
         ImportDirective,
         StringLiteral,
         UriBasedDirective,
         parseDirectives;
 import 'package:analyzer/src/generated/source.dart' show Source;
 import 'package:dev_compiler/src/analyzer/context.dart' show AnalyzerOptions;
@@ skipping 19 matching lines @@
 /// The tests sometimes import utility libraries using a relative path.
 /// Likewise, the multitests do too, and one multitest even imports its own
 /// non-expanded form (!). To make that simpler, we copy the entire test tree
 /// to a generated directory and expand that multitests in there too.
 final codegenTestDir = path.join(repoDirectory, 'gen', 'codegen_tests');
 
 /// The generated directory where tests and packages compiled to JS are
 /// output.
 final codegenOutputDir = path.join(repoDirectory, 'gen', 'codegen_output');
 
-// TODO(jmesserly): switch this to a .packages file.
-final packageUrlMappings = {
-  'package:expect/expect.dart': path.join(codegenDir, 'expect.dart'),
-  'package:async_helper/async_helper.dart':
-      path.join(codegenDir, 'async_helper.dart'),
-  'package:js/js.dart': path.join(codegenDir, 'packages', 'js', 'js.dart')
-};
-
 final codeCoverage = Platform.environment.containsKey('COVERALLS_TOKEN');
 
 RegExp filePattern;
 
 main(List<String> arguments) {
   if (arguments == null) arguments = [];
   ArgResults args = argParser.parse(arguments);
   filePattern = new RegExp(args.rest.length > 0 ? args.rest[0] : '.');
 
   var sdkDir = path.join(repoDirectory, 'gen', 'patched_sdk');
   var sdkSummaryFile =
       path.join(testDirectory, '..', 'lib', 'runtime', 'dart_sdk.sum');
+
+  var summaryPaths = new Directory(path.join(codegenOutputDir, 'pkg'))
+      .listSync()
+      .map((e) => e.path)
+      .where((p) => p.endsWith('.sum'))
+      .toList();
+
   var analyzerOptions = new AnalyzerOptions(
-      customUrlMappings: packageUrlMappings,
-      dartSdkSummaryPath: sdkSummaryFile);
+      dartSdkSummaryPath: sdkSummaryFile, summaryPaths: summaryPaths);
   var compiler = new ModuleCompiler(analyzerOptions);
 
-  // Build packages tests depend on.
-  _buildAllPackages(compiler);
-
   var testDirs = [
     'language',
     'corelib',
     path.join('lib', 'convert'),
     path.join('lib', 'html'),
     path.join('lib', 'math'),
     path.join('lib', 'typed_data'),
   ];
 
   // Copy all of the test files and expanded multitest files to
@@ skipping 37 matching lines @@
       var unit = new BuildUnit(moduleName, path.dirname(testFile),
           files.toList(), _moduleForLibrary);
       var module = compiler.compile(unit, options);
       _writeModule(
           path.join(outDir, path.basenameWithoutExtension(testFile)),
           path.join(expectDir, path.basenameWithoutExtension(testFile)),
           module);
     });
   }
 
+  if (filePattern.hasMatch('sunflower')) {
+    _buildSunflower(compiler, codegenOutputDir, codegenExpectDir);
+  }
+
   if (codeCoverage) {
     test('build_sdk code coverage', () {
       return build_sdk.main(['--dart-sdk', sdkDir, '-o', codegenOutputDir]);
     });
   }
 }
 
 void _writeModule(String outPath, String expectPath, JSModuleFile result) {
   _ensureDirectory(path.dirname(outPath));
   _ensureDirectory(path.dirname(expectPath));
 
   String errors = result.errors.join('\n');
   if (errors.isNotEmpty && !errors.endsWith('\n')) errors += '\n';
   new File(outPath + '.txt').writeAsStringSync(errors);
 
   var jsFile = new File(outPath + '.js');
+  var summaryFile = new File(outPath + '.sum');
   var expectFile = new File(expectPath + '.js');
   var errorFile = new File(outPath + '.err');
 
   if (result.isValid) {
     jsFile.writeAsStringSync(result.code);
+    if (result.summaryBytes != null) {
+      summaryFile.writeAsBytesSync(result.summaryBytes);
+    }
     if (result.sourceMap != null) {
       var mapPath = outPath + '.js.map';
       new File(mapPath)
           .writeAsStringSync(JSON.encode(result.placeSourceMap(mapPath)));
     }
 
     expectFile.writeAsStringSync(result.code);
 
     // There are no errors, so delete any stale ".err" file.
     if (errorFile.existsSync()) {
@@ skipping 25 matching lines @@
     }
 
     // There are errors, so delete any stale expect ".js" file.
     if (expectFile.existsSync()) {
       expectFile.deleteSync();
     }
     expectFile.writeAsStringSync("//FAILED TO COMPILE");
   }
 }
 
-void _buildAllPackages(ModuleCompiler compiler) {
-  group('dartdevc package', () {
-    _buildPackages(compiler, codegenOutputDir, codegenExpectDir);
-
-    var packages = ['matcher', 'path', 'stack_trace'];
-    for (var package in packages) {
-      if (!filePattern.hasMatch(package)) continue;
-      test(package, () {
-        _buildPackage(compiler, codegenOutputDir, codegenExpectDir, package);
-      });
-    }
-
-    if (!filePattern.hasMatch('unittest')) return;
-
-    test('unittest', () {
-      // Only build files applicable to the web - html_*.dart and its
-      // internal dependences.
-      _buildPackage(compiler, codegenOutputDir, codegenExpectDir, "unittest",
-          packageFiles: [
-            'unittest.dart',
-            'html_config.dart',
-            'html_individual_config.dart',
-            'html_enhanced_config.dart'
-          ]);
-    });
-  });
-
-  if (!filePattern.hasMatch('sunflower')) return;
-
-  test('dartdevc sunflower', () {
-    _buildSunflower(compiler, codegenOutputDir, codegenExpectDir);
-  });
-}
-
 void _buildSunflower(
     ModuleCompiler compiler, String outputDir, String expectDir) {
   var baseDir = path.join(codegenDir, 'sunflower');
   var files = ['sunflower', 'circle', 'painter']
       .map((f) => path.join(baseDir, '$f.dart'))
       .toList();
   var input = new BuildUnit('sunflower', baseDir, files, _moduleForLibrary);
   var options = new CompilerOptions(summarizeApi: false);
 
   var built = compiler.compile(input, options);
   _writeModule(path.join(outputDir, 'sunflower', 'sunflower'),
       path.join(expectDir, 'sunflower', 'sunflower'), built);
 }
 
-void _buildPackages(
-    ModuleCompiler compiler, String outputDir, String expectDir) {
-  // Note: we don't summarize these, as we're going to rely on our in-memory
-  // shared analysis context for caching, and `_moduleForLibrary` below
-  // understands these are from other modules.
-  var options = new CompilerOptions(sourceMap: false, summarizeApi: false);
-
-  for (var uri in packageUrlMappings.keys) {
-    if (!filePattern.hasMatch(uri)) return;
-
-    assert(uri.startsWith('package:'));
-    var uriPath = uri.substring('package:'.length);
-    var name = path.basenameWithoutExtension(uriPath);
-    test(name, () {
-      var input = new BuildUnit(name, codegenDir, [uri], _moduleForLibrary);
-      var built = compiler.compile(input, options);
-
-      var outPath = path.join(outputDir, path.withoutExtension(uriPath));
-      var expectPath = path.join(expectDir, path.withoutExtension(uriPath));
-      _writeModule(outPath, expectPath, built);
-    });
-  }
-}
-
-void _buildPackage(
-    ModuleCompiler compiler, String outputDir, String expectDir, packageName,
-    {List<String> packageFiles}) {
-  var options = new CompilerOptions(sourceMap: false, summarizeApi: false);
-
-  var packageRoot = path.join(codegenDir, 'packages');
-  var packageInputDir = path.join(packageRoot, packageName);
-  List<String> files;
-  if (packageFiles != null) {
-    // Only collect files transitively reachable from packageFiles.
-    var reachable = new Set<String>();
-    for (var file in packageFiles) {
-      file = path.join(packageInputDir, file);
-      _collectTransitiveImports(new File(file).readAsStringSync(), reachable,
-          packageRoot: packageRoot, from: file);
-    }
-    files = reachable.toList();
-  } else {
-    // Collect all files in the packages directory.
-    files = new Directory(packageInputDir)
-        .listSync(recursive: true)
-        .where((entry) => entry.path.endsWith('.dart'))
-        .map((entry) => entry.path)
-        .toList();
-  }
-
-  var unit =
-      new BuildUnit(packageName, packageInputDir, files, _moduleForLibrary);
-  var module = compiler.compile(unit, options);
-
-  var outPath = path.join(outputDir, packageName, packageName);
-  var expectPath = path.join(expectDir, packageName, packageName);
-  _writeModule(outPath, expectPath, module);
-}
-
 String _moduleForLibrary(Source source) {
   var scheme = source.uri.scheme;
   if (scheme == 'package') {
     return source.uri.pathSegments.first;
   }
   throw new Exception('Module not found for library "${source.fullName}"');
 }
 
 List<String> _setUpTests(List<String> testDirs) {
   var testFiles = <String>[];
@@ skipping 103 matching lines @@
 /// Simplified from ParseDartTask.resolveDirective.
 String _resolveDirective(UriBasedDirective directive) {
   StringLiteral uriLiteral = directive.uri;
   String uriContent = uriLiteral.stringValue;
   if (uriContent != null) {
     uriContent = uriContent.trim();
     directive.uriContent = uriContent;
   }
   return directive.validate() == null ? uriContent : null;
 }