Issue 22343003: Rollback of r16040 in trunk branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22343003: Rollback of r16040 in trunk branch. (Closed)

Created:
7 years, 4 months ago by danno

Modified:
7 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/trunk

Visibility:
Public.

Rollback of r16040 in trunk branch. Make GlobalHandle::NodeBlock deletable R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16104

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+209 lines, -645 lines)			Patch
M	src/global-handles.h	View	3 chunks	+7 lines, -57 lines	0 comments	Download
M	src/global-handles.cc	View	10 chunks	+149 lines, -380 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/cctest.h	View	1 chunk	+0 lines, -53 lines	0 comments	Download
M	test/cctest/test-global-handles.cc	View	2 chunks	+0 lines, -154 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	1 chunk	+52 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

danno

7 years, 4 months ago (2013-08-07 16:19:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16104 (presubmit successful).