chrome/browser/extensions/api/settings_private/prefs_util.cc - Issue 2234203002: Auto open and close the palette on an eject event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_private/prefs_util.cc

Issue 2234203002: Auto open and close the palette on an eject event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tool-note

Patch Set: Rebase on master Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/common/test/test_palette_delegate.h ('K') | « chrome/browser/chromeos/preferences.cc ('k') | chrome/browser/resources/options/chromeos/note_overlay.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_private/prefs_util.cc

diff --git a/chrome/browser/extensions/api/settings_private/prefs_util.cc b/chrome/browser/extensions/api/settings_private/prefs_util.cc

index 666e205781202959afa298a1f5af3966599f203c..5276912930fa4ed6727fb02ed74331e3023a3ad4 100644

--- a/chrome/browser/extensions/api/settings_private/prefs_util.cc

+++ b/chrome/browser/extensions/api/settings_private/prefs_util.cc

@@ -259,7 +259,7 @@ const PrefsUtil::TypedPrefMap& PrefsUtil::GetWhitelistedKeys() {

settings_private::PrefType::PREF_TYPE_STRING;

(*s_whitelist)["settings.language.enabled_extension_imes"] =

settings_private::PrefType::PREF_TYPE_STRING;

- (*s_whitelist)["settings.launch_note_app_on_eject_event"] =

+ (*s_whitelist)["settings.launch_palette_on_eject_event "] =

oshima 2016/08/24 23:38:50 nit: extra white-space.

jdufault 2016/08/24 23:54:07 Done, good catch!

settings_private::PrefType::PREF_TYPE_BOOLEAN;

// Device settings.