Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 2234193002: DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 15 matching lines...) Expand all
26 26
27 /** 27 /**
28 * @constructor 28 * @constructor
29 * @extends {WebInspector.SimpleView} 29 * @extends {WebInspector.SimpleView}
30 */ 30 */
31 WebInspector.ScopeChainSidebarPane = function() 31 WebInspector.ScopeChainSidebarPane = function()
32 { 32 {
33 WebInspector.SimpleView.call(this, WebInspector.UIString("Scope")); 33 WebInspector.SimpleView.call(this, WebInspector.UIString("Scope"));
34 this._expandController = new WebInspector.ObjectPropertiesSectionExpandContr oller(); 34 this._expandController = new WebInspector.ObjectPropertiesSectionExpandContr oller();
35 this._linkifier = new WebInspector.Linkifier(); 35 this._linkifier = new WebInspector.Linkifier();
36 WebInspector.context.addFlavorChangeListener(WebInspector.DebuggerModel.Call Frame, this._update, this);
36 } 37 }
37 38
38 WebInspector.ScopeChainSidebarPane._pathSymbol = Symbol("path"); 39 WebInspector.ScopeChainSidebarPane._pathSymbol = Symbol("path");
39 40
40 WebInspector.ScopeChainSidebarPane.prototype = { 41 WebInspector.ScopeChainSidebarPane.prototype = {
41 /** 42 _update: function()
42 * @param {?WebInspector.DebuggerModel.CallFrame} callFrame
43 */
44 update: function(callFrame)
45 { 43 {
44 var callFrame = WebInspector.context.flavor(WebInspector.DebuggerModel.C allFrame);
46 this._linkifier.reset(); 45 this._linkifier.reset();
47 WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame) 46 WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame)
48 .then(this._innerUpdate.bind(this, callFrame)); 47 .then(this._innerUpdate.bind(this, callFrame));
49 }, 48 },
50 49
51 /** 50 /**
52 * @param {?WebInspector.DebuggerModel.CallFrame} callFrame 51 * @param {?WebInspector.DebuggerModel.CallFrame} callFrame
53 * @param {?WebInspector.RemoteObject} thisObject 52 * @param {?WebInspector.RemoteObject} thisObject
54 */ 53 */
55 _innerUpdate: function(callFrame, thisObject) 54 _innerUpdate: function(callFrame, thisObject)
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 section.element.classList.add("scope-chain-sidebar-pane-section"); 132 section.element.classList.add("scope-chain-sidebar-pane-section");
134 this.element.appendChild(section.element); 133 this.element.appendChild(section.element);
135 } 134 }
136 this._sidebarPaneUpdatedForTest(); 135 this._sidebarPaneUpdatedForTest();
137 }, 136 },
138 137
139 _sidebarPaneUpdatedForTest: function() { }, 138 _sidebarPaneUpdatedForTest: function() { },
140 139
141 __proto__: WebInspector.SimpleView.prototype 140 __proto__: WebInspector.SimpleView.prototype
142 } 141 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698