Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2234193002: DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 624 matching lines...) Expand 10 before | Expand all | Expand 10 after
635 * @this {WebInspector.DebuggerModel} 635 * @this {WebInspector.DebuggerModel}
636 */ 636 */
637 function didEvaluate(result, wasThrown, exceptionDetails) 637 function didEvaluate(result, wasThrown, exceptionDetails)
638 { 638 {
639 if (!result) 639 if (!result)
640 callback(null, false); 640 callback(null, false);
641 else if (returnByValue) 641 else if (returnByValue)
642 callback(null, !!wasThrown, wasThrown ? null : result, exception Details); 642 callback(null, !!wasThrown, wasThrown ? null : result, exception Details);
643 else 643 else
644 callback(this.target().runtimeModel.createRemoteObject(result), !!wasThrown, undefined, exceptionDetails); 644 callback(this.target().runtimeModel.createRemoteObject(result), !!wasThrown, undefined, exceptionDetails);
645
646 if (objectGroup === "console")
647 this.dispatchEventToListeners(WebInspector.DebuggerModel.Events. ConsoleCommandEvaluatedInSelectedCallFrame);
648 } 645 }
649 646
650 this.selectedCallFrame().evaluate(code, objectGroup, includeCommandLineA PI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, didEva luate.bind(this)); 647 this.selectedCallFrame().evaluate(code, objectGroup, includeCommandLineA PI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, didEva luate.bind(this));
651 }, 648 },
652 649
653 /** 650 /**
654 * @param {!WebInspector.RemoteObject} remoteObject 651 * @param {!WebInspector.RemoteObject} remoteObject
655 * @return {!Promise<?WebInspector.DebuggerModel.FunctionDetails>} 652 * @return {!Promise<?WebInspector.DebuggerModel.FunctionDetails>}
656 */ 653 */
657 functionDetailsPromise: function(remoteObject) 654 functionDetailsPromise: function(remoteObject)
(...skipping 633 matching lines...) Expand 10 before | Expand all | Expand 10 after
1291 /** 1288 /**
1292 * @param {?WebInspector.Target} target 1289 * @param {?WebInspector.Target} target
1293 * @return {?WebInspector.DebuggerModel} 1290 * @return {?WebInspector.DebuggerModel}
1294 */ 1291 */
1295 WebInspector.DebuggerModel.fromTarget = function(target) 1292 WebInspector.DebuggerModel.fromTarget = function(target)
1296 { 1293 {
1297 if (!target || !target.hasJSCapability()) 1294 if (!target || !target.hasJSCapability())
1298 return null; 1295 return null;
1299 return /** @type {?WebInspector.DebuggerModel} */ (target.model(WebInspector .DebuggerModel)); 1296 return /** @type {?WebInspector.DebuggerModel} */ (target.model(WebInspector .DebuggerModel));
1300 } 1297 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698