DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars.

third_party/WebKit/Source/devtools/front_end/ui/View.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @interface
  */
 WebInspector.View = function()
 {
 }
@@ skipping 23 matching lines @@
      * @return {!Promise<!Array<!WebInspector.ToolbarItem>>}
      */
     toolbarItems: function() { },
 
     /**
      * @return {!Promise<!WebInspector.Widget>}
      */
     widget: function() { }
 }
 
+WebInspector.View._symbol = Symbol("view");
+
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  * @implements {WebInspector.View}
  * @param {string} title
  * @param {boolean=} isWebComponent
  */
 WebInspector.SimpleView = function(title, isWebComponent)
 {
     WebInspector.VBox.call(this, isWebComponent);
     this._title = title;
     /** @type {!Array<!WebInspector.ToolbarItem>} */
     this._toolbarItems = [];
+    this[WebInspector.View._symbol] = this;
 }
 
 WebInspector.SimpleView.prototype = {
     /**
      * @override
      * @return {string}
      */
     viewId: function()
     {
         return this._title;
@@ skipping 117 matching lines @@
     {
         return this._extension.descriptor()["persistence"] === "transient";
     },
 
     /**
      * @override
      * @return {!Promise<!Array<!WebInspector.ToolbarItem>>}
      */
     toolbarItems: function()
     {
+        var actionIds = this._extension.descriptor()["actionIds"];
+        if (actionIds) {
+            var result = []
+            for (var id of actionIds.split(",")) {
+                var item = WebInspector.Toolbar.createActionButtonForId(id.trim());
+                if (item)
+                    result.push(item);
+            }
+            return Promise.resolve(result);
+        }
+
+        if (this._extension.descriptor()["hasToolbar"]) {
+            return this.widget().then(widget => {
+                return /** @type {!WebInspector.ToolbarItem.ItemsProvider} */ (widget).toolbarItems();

[dgozman, 2016/08/11 01:42:16]

Drop { return }

+            });
+        }
         return Promise.resolve([]);
     },
 
     /**
      * @override
      * @return {!Promise<!WebInspector.Widget>}
      */
     widget: function()
     {
-        return  /** @type {!Promise<!WebInspector.Widget>} */ (this._extension.instance());
+        return this._extension.instance().then(widget => {
+            if (!(widget instanceof WebInspector.Widget))
+                throw new Error("view className should point to a WebInspector.Widget");
+            widget[WebInspector.View._symbol] = this;
+            return  /** @type {!WebInspector.Widget} */ (widget);
+        });
     }
 }
 
 /**
  * @interface
  */
 WebInspector.ViewLocation = function() { }
 
 WebInspector.ViewLocation.prototype = {
     /**
@@ skipping 60 matching lines @@
 
     for (var extension of self.runtime.extensions("view")) {
         var descriptor = extension.descriptor();
         this._views.set(descriptor["id"], new WebInspector.ProvidedView(extension));
         this._locationNameByViewId.set(descriptor["id"], descriptor["location"]);
     }
 }
 
 WebInspector.ViewManager.prototype = {
     /**
+     * @param {!WebInspector.Widget} widget
+     */
+    revealViewWithWidget: function(widget)
+    {
+        var view = widget[WebInspector.View._symbol];
+        if (view)
+            this.revealView(view);
+    },
+
+    /**
      * @param {!WebInspector.View} view
      * @return {!Promise}
      */
     revealView: function(view)
     {
         var location = /** @type {?WebInspector.ViewManager._Location} */ (view[WebInspector.ViewManager._Location.symbol]);
         if (!location)
             return Promise.resolve();
         location._reveal();
         return location.showView(view);
@@ skipping 481 matching lines @@
             this.appendView(view);
     },
 
     __proto__: WebInspector.ViewManager._Location.prototype
 }
 
 /**
  * @type {!WebInspector.ViewManager}
  */
 WebInspector.viewManager;