DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars.

third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 604 matching lines @@
                     buttons[i].element.classList.remove("emulate-active");
                     buttons[i]._clicked(e);
                     break;
                 }
             }
         }
     }
 }
 
 /**
+ * @param {string} actionId
+ * @return {?WebInspector.ToolbarItem}
+ */
+WebInspector.Toolbar.createActionButtonForId = function(actionId)
+{
+    var action = WebInspector.actionRegistry.action(actionId);
+    return /** @type {?WebInspector.ToolbarItem} */(action ? WebInspector.Toolbar.createActionButton(action) : null)

[dgozman, 2016/08/11 01:42:16]

style: semicolon

+}
+
+/**
  * @constructor
  * @extends {WebInspector.ToolbarButton}
  * @param {function(!WebInspector.ContextMenu)} contextMenuHandler
  * @param {boolean=} useSoftMenu
  */
 WebInspector.ToolbarMenuButton = function(contextMenuHandler, useSoftMenu)
 {
     WebInspector.ToolbarButton.call(this, "", "menu-toolbar-item");
     this._contextMenuHandler = contextMenuHandler;
     this._useSoftMenu = !!useSoftMenu;
@@ skipping 105 matching lines @@
 }
 
 WebInspector.ToolbarItem.Provider.prototype = {
     /**
      * @return {?WebInspector.ToolbarItem}
      */
     item: function() {}
 }
 
 /**
+ * @interface
+ */
+WebInspector.ToolbarItem.ItemsProvider = function()
+{
+}
+
+WebInspector.ToolbarItem.ItemsProvider.prototype = {
+    /**
+     * @return {!Array<!WebInspector.ToolbarItem>}
+     */
+    toolbarItems: function() {}
+}
+
+/**
  * @constructor
  * @extends {WebInspector.ToolbarItem}
  * @param {?function(!Event)} changeHandler
  * @param {string=} className
  */
 WebInspector.ToolbarComboBox = function(changeHandler, className)
 {
     WebInspector.ToolbarItem.call(this, createElementWithClass("span", "toolbar-select-container"));
 
     this._selectElement = this.element.createChild("select", "toolbar-item");
@@ skipping 189 matching lines @@
 
         /**
          * @param {!Runtime.Extension} extension
          * @return {!Promise.<?WebInspector.ToolbarItem>}
          */
         function resolveItem(extension)
         {
             var descriptor = extension.descriptor();
             if (descriptor["separator"])
                 return Promise.resolve(/** @type {?WebInspector.ToolbarItem} */(new WebInspector.ToolbarSeparator()));
-            if (descriptor["actionId"]) {
-                var action = WebInspector.actionRegistry.action(descriptor["actionId"]);
-                return Promise.resolve(/** @type {?WebInspector.ToolbarItem} */(action ? WebInspector.Toolbar.createActionButton(action) : null));
-            }
+            if (descriptor["actionId"])
+                return Promise.resolve(WebInspector.Toolbar.createActionButtonForId(descriptor["actionId"]));
             return extension.instance().then(fetchItemFromProvider);
 
             /**
              * @param {!Object} provider
              */
             function fetchItemFromProvider(provider)
             {
                 return /** @type {!WebInspector.ToolbarItem.Provider} */ (provider).item();
             }
         }
 
         /**
          * @param {!Array.<?WebInspector.ToolbarItem>} items
          * @this {WebInspector.ExtensibleToolbar}
          */
         function appendItemsInOrder(items)
         {
             for (var i = 0; i < items.length; ++i) {
                 var item = items[i];
                 if (item)
                     this.appendToolbarItem(item);
             }
         }
     },
 
     __proto__: WebInspector.Toolbar.prototype
 }