DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars.

third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 18 matching lines @@
  */
 WebInspector.CallStackSidebarPane = function()
 {
     WebInspector.SimpleView.call(this, WebInspector.UIString("Call Stack"));
     this.element.addEventListener("keydown", this._keyDown.bind(this), true);
     this.element.tabIndex = 0;
     this.callFrameList = new WebInspector.UIList();
     this.callFrameList.show(this.element);
     this._linkifier = new WebInspector.Linkifier();
     WebInspector.moduleSetting("enableAsyncStackTraces").addChangeListener(this._asyncStackTracesStateChanged, this);
-    WebInspector.moduleSetting("skipStackFramesPattern").addChangeListener(this._blackboxingStateChanged, this);
+    WebInspector.moduleSetting("skipStackFramesPattern").addChangeListener(this._update, this);
     /** @type {!Array<!WebInspector.CallStackSidebarPane.CallFrame>} */
     this.callFrames = [];
     this._locationPool = new WebInspector.LiveLocationPool();
-}
-
-/** @enum {string} */
-WebInspector.CallStackSidebarPane.Events = {
-    CallFrameSelected: "CallFrameSelected",
+    WebInspector.targetManager.addModelListener(WebInspector.DebuggerModel, WebInspector.DebuggerModel.Events.DebuggerPaused, this._update, this);
+    WebInspector.targetManager.addModelListener(WebInspector.DebuggerModel, WebInspector.DebuggerModel.Events.DebuggerResumed, this._update, this);
+    WebInspector.context.addFlavorChangeListener(WebInspector.Target, this._update, this);
+    WebInspector.context.addFlavorChangeListener(WebInspector.DebuggerModel.CallFrame, this._updateCallFrame, this);
 }
 
 WebInspector.CallStackSidebarPane.prototype = {
-    /**
-     * @param {?WebInspector.DebuggerPausedDetails} details
-     */
-    update: function(details)
+    _update: function()
     {
+        var target = WebInspector.context.flavor(WebInspector.Target);
+        var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);
+        var details = debuggerModel.debuggerPausedDetails();

[dgozman, 2016/08/11 01:42:16]

debuggerModel could be null

+
         this.callFrameList.detach();
         this.callFrameList.clear();
         this._linkifier.reset();
         this.element.removeChildren();
         this._locationPool.disposeAll();
 
         if (!details) {
             var infoElement = this.element.createChild("div", "callstack-info");
             infoElement.textContent = WebInspector.UIString("Not Paused");
             return;
@@ skipping 28 matching lines @@
                 element.textContent = WebInspector.UIString("1 stack frame is hidden (black-boxed).");
             else
                 element.textContent = WebInspector.UIString("%d stack frames are hidden (black-boxed).", this._hiddenCallFrames);
             element.createTextChild(" ");
             var showAllLink = element.createChild("span", "link");
             showAllLink.textContent = WebInspector.UIString("Show");
             showAllLink.addEventListener("click", this._revealHiddenCallFrames.bind(this), false);
             this.element.insertBefore(element, this.element.firstChild);
             this._hiddenCallFramesMessageElement = element;
         }
+        WebInspector.viewManager.revealViewWithWidget(this);
     },
 
     /**
      * @param {!Array.<!WebInspector.DebuggerModel.CallFrame>} callFrames
      * @return {!Array<!WebInspector.CallStackSidebarPane.CallFrame>}
      */
     _callFramesFromDebugger: function(callFrames)
     {
         var callFrameItems = [];
         for (var i = 0, n = callFrames.length; i < n; ++i) {
@@ skipping 127 matching lines @@
                 contextMenu.appendItem(WebInspector.UIString.capitalize("Blackbox ^script"), manager.blackboxUISourceCode.bind(manager, uiSourceCode));
         }
         if (isContentScript) {
             if (isBlackboxed)
                 contextMenu.appendItem(WebInspector.UIString.capitalize("Stop blackboxing ^all ^content ^scripts"), manager.blackboxContentScripts.bind(manager));
             else
                 contextMenu.appendItem(WebInspector.UIString.capitalize("Blackbox ^all ^content ^scripts"), manager.unblackboxContentScripts.bind(manager));
         }
     },
 
-    _blackboxingStateChanged: function()
-    {
-        if (!this._debuggerModel)
-            return;
-        var details = this._debuggerModel.debuggerPausedDetails();
-        if (!details)
-            return;
-        this.update(details);
-        var selectedCallFrame = this._debuggerModel.selectedCallFrame();
-        if (selectedCallFrame)
-            this.setSelectedCallFrame(selectedCallFrame);
-    },
-
     _asyncStackTracesStateChanged: function()
     {
         var enabled = WebInspector.moduleSetting("enableAsyncStackTraces").get();
         if (!enabled && this.callFrames)
             this._removeAsyncCallFrames();
     },
 
     _removeAsyncCallFrames: function()
     {
         var shouldSelectTopFrame = false;
         var lastSyncCallFrameIndex = -1;
         for (var i = 0; i < this.callFrames.length; ++i) {
             var callFrame = this.callFrames[i];
             if (callFrame._asyncCallFrame) {
                 if (callFrame.isSelected())
                     shouldSelectTopFrame = true;
                 callFrame._asyncCallFrame.element.remove();
                 callFrame.element.remove();
             } else {
                 lastSyncCallFrameIndex = i;
             }
         }
         this.callFrames.length = lastSyncCallFrameIndex + 1;
         if (shouldSelectTopFrame)
             this._selectNextVisibleCallFrame(0);
     },
 
-    /**
-     * @param {!WebInspector.DebuggerModel.CallFrame} x
-     */
-    setSelectedCallFrame: function(x)
+    _updateCallFrame: function()
     {
+        var x = WebInspector.context.flavor(WebInspector.DebuggerModel.CallFrame);

[dgozman, 2016/08/11 01:42:16]

x -> selectedCallFrame

         for (var i = 0; i < this.callFrames.length; ++i) {
             var callFrame = this.callFrames[i];
             callFrame.setSelected(callFrame._debuggerCallFrame === x);
             if (callFrame.isSelected() && callFrame.isHidden())
                 this._revealHiddenCallFrames();
         }
     },
 
     /**
      * @return {boolean}
@@ skipping 62 matching lines @@
     },
 
     /**
      * @param {!WebInspector.CallStackSidebarPane.CallFrame} callFrameItem
      */
     _callFrameSelected: function(callFrameItem)
     {
         callFrameItem.element.scrollIntoViewIfNeeded();
         var callFrame = callFrameItem._debuggerCallFrame;
         if (callFrame)
-            this.dispatchEventToListeners(WebInspector.CallStackSidebarPane.Events.CallFrameSelected, callFrame);
+            callFrame.debuggerModel.setSelectedCallFrame(callFrame);
     },
 
     _copyStackTrace: function()
     {
         var text = "";
         var lastCallFrame = null;
         for (var i = 0; i < this.callFrames.length; ++i) {
             var callFrame = this.callFrames[i];
             if (callFrame.isHidden())
                 continue;
@@ skipping 76 matching lines @@
         var uiLocation = liveLocation.uiLocation();
         if (!uiLocation)
             return;
         var text = uiLocation.linkText();
         this.setSubtitle(text.trimMiddle(30));
         this.subtitleElement.title = text;
     },
 
     __proto__: WebInspector.UIList.Item.prototype
 }