Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2234183002: cc: Change visible rect in content space calculation to not overflow. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Change visible rect in content space calculation to not overflow. This patch changes the intersect call to use safe intersect math since the rect intersect version might overflow (although it is likely faster) R=enne, danakj BUG=635432 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/fc7eed4f2a4fbb35d1d243ca07fac20dcb20b07f Cr-Commit-Position: refs/heads/master@{#411396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M cc/layers/picture_layer_impl.cc View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-08-10 23:57:27 UTC) #2
enne (OOO)
lgtm
4 years, 4 months ago (2016-08-11 00:01:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234183002/1
4 years, 4 months ago (2016-08-11 00:03:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/120512)
4 years, 4 months ago (2016-08-11 02:58:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234183002/1
4 years, 4 months ago (2016-08-11 17:37:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 19:17:07 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 19:18:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc7eed4f2a4fbb35d1d243ca07fac20dcb20b07f
Cr-Commit-Position: refs/heads/master@{#411396}

Powered by Google App Engine
This is Rietveld 408576698