third_party/WebKit/LayoutTests/svg/hittest/empty-container.html - Issue 2234173002: Skip hit testing containers with invalid bounding boxes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/hittest/empty-container.html

Issue 2234173002: Skip hit testing containers with invalid bounding boxes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <style>

	5 * {

	6 margin: 0;

	7 }

	8 svg {

	9 pointer-events: bounding-box;

	10 }

	11 </style>

	12 <svg id="svg" width="200" height="200">

	13 <g></g>

	14 </svg>

	15 Hit testing an empty container should not crash.
	fs 2016/08/11 15:22:04 To mesh better with testharness, this should proba To mesh better with testharness, this should probably be put as a <title> (which then will be picked up as the "name" for the test().) pdr. 2016/08/11 22:51:24 Done and confirmed the failure text looks nicer no Show quoted text On 2016/08/11 at 15:22:04, fs (OoO until Aug 15) wrote: > To mesh better with testharness, this should probably be put as a <title> (which then will be picked up as the "name" for the test().) Done and confirmed the failure text looks nicer now.
	16 <script>

	17 test(function() {

	18 var checkOrigin = document.elementFromPoint(0, 0);

	19 assert_equals(checkOrigin, svg, "element @ 0, 0");

	20

	21 var checkPoint = document.elementFromPoint(50, 50);

	22 assert_equals(checkPoint, svg, "element @ 50, 50");

	23 });

	24 </script>

OLD	NEW