[SVGDom] Add more presentation attributes.

[SVGDom] Add more presentation attributes.

Implement proper presentation attribute inheritance, and add
support for

* fill-opacity
* stroke-linecap
* stroke-linejoin
* stroke-opacity
* stroke-width


R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234153002

Committed: https://skia.googlesource.com/skia/+/2d961e086bb40b371b1a667536fa089794847368

[f(malita), 2016-08-10 22:47:01]

Description was changed from

==========
[SVGDom] Add more presentation attributes.

* fill-opacity
* stroke-linecap
* stroke-linejoin
* stroke-opacity
* stroke-width



BUG=skia:
==========

to

==========
[SVGDom] Add more presentation attributes.

* fill-opacity
* stroke-linecap
* stroke-linejoin
* stroke-opacity
* stroke-width



BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234153002
==========

[f(malita), 2016-08-11 12:45:36]

Description was changed from

==========
[SVGDom] Add more presentation attributes.

* fill-opacity
* stroke-linecap
* stroke-linejoin
* stroke-opacity
* stroke-width



BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234153002
==========

to

==========
[SVGDom] Add more presentation attributes.

Implement proper presentation attribute inheritance, and add
support for

* fill-opacity
* stroke-linecap
* stroke-linejoin
* stroke-opacity
* stroke-width


R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234153002
==========

[f(malita), 2016-08-11 12:52:07]

fmalita@chromium.org changed reviewers:
+ robertphillips@google.com, stephana@google.com

[f(malita), 2016-08-11 13:04:26]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 13:04:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 13:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 13:34:44]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-11 13:38:54]

https://codereview.chromium.org/2234153002/diff/80001/experimental/svg/model/...
File experimental/svg/model/SkSVGAttribute.h (right):

https://codereview.chromium.org/2234153002/diff/80001/experimental/svg/model/...
experimental/svg/model/SkSVGAttribute.h:36: 
Why go from class to struct ?

https://codereview.chromium.org/2234153002/diff/80001/experimental/svg/model/...
experimental/svg/model/SkSVGAttribute.h:41: 
Since we're now accumulating SkPaint fragments, should fFill be fFillColor?

https://codereview.chromium.org/2234153002/diff/80001/experimental/svg/model/...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2234153002/diff/80001/experimental/svg/model/...
experimental/svg/model/SkSVGRenderContext.cpp:32: switch (l.unit()) {
// fall through ?

[f(malita), 2016-08-11 14:03:17]

https://codereview.chromium.org/2234153002/diff/80001/experimental/svg/model/...
File experimental/svg/model/SkSVGAttribute.h (right):

https://codereview.chromium.org/2234153002/diff/80001/experimental/svg/model/...
experimental/svg/model/SkSVGAttribute.h:36: 
On 2016/08/11 13:38:54, robertphillips wrote:
> Why go from class to struct ?

Just to simplify access, since this has been reduced to a trivial container (all
the logic is now in SkSVGRenderContext/SkSVGPresentationContext).

Would you prefer a class with public fields or maybe full encapsulation with
getters/setters?

(FWIW I'm not happy with the current verbose/boiler-platey presentation
attribute definition and handling, and am looking for ways to
refactor/simplify).

https://codereview.chromium.org/2234153002/diff/80001/experimental/svg/model/...
experimental/svg/model/SkSVGAttribute.h:41: 
On 2016/08/11 13:38:54, robertphillips wrote:
> Since we're now accumulating SkPaint fragments, should fFill be fFillColor?

The SkPaints are just a cache, to avoid reconstructing unnecessarily (possibly
premature optimization:).

But we still need to accumulate/track full SVG paint info - which includes
special values like "none" "currentColor" "inherit" and, in the future, paint
server refs (for e.g. gradients).

https://codereview.chromium.org/2234153002/diff/80001/experimental/svg/model/...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2234153002/diff/80001/experimental/svg/model/...
experimental/svg/model/SkSVGRenderContext.cpp:32: switch (l.unit()) {
On 2016/08/11 13:38:54, robertphillips wrote:
> // fall through ?

Done.

[f(malita), 2016-08-11 14:03:25]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 14:03:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 14:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 14:33:29]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-11 15:04:08]

lgtm

[f(malita), 2016-08-11 16:15:07]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-08-11 16:15:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 16:16:32]

Description was changed from

==========
[SVGDom] Add more presentation attributes.

Implement proper presentation attribute inheritance, and add
support for

* fill-opacity
* stroke-linecap
* stroke-linejoin
* stroke-opacity
* stroke-width


R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234153002
==========

to

==========
[SVGDom] Add more presentation attributes.

Implement proper presentation attribute inheritance, and add
support for

* fill-opacity
* stroke-linecap
* stroke-linejoin
* stroke-opacity
* stroke-width


R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234153002

Committed:
https://skia.googlesource.com/skia/+/2d961e086bb40b371b1a667536fa089794847368
==========

[commit-bot: I haz the power, 2016-08-11 16:16:33]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/2d961e086bb40b371b1a667536fa089794847368