Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2234143003: Revert of Mac: Share kScrollbarPixelsPerCocoaTick between ui:: and blink:: events (Closed)

Created:
4 years, 4 months ago by tapted
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mac: Share kScrollbarPixelsPerCocoaTick between ui:: and blink:: events (patchset #5 id:140001 of https://codereview.chromium.org/2226933004/ ) Reason for revert: Somehow... this slipped through the trybots - web_input_event_builders_mac_unittest.mm:586:49:error: too many arguments to function call, expected 2, have 4 Original issue's description: > Mac: Share kScrollbarPixelsPerCocoaTick between ui:: and blink:: events > > Currently scrolling in MacViews with a "real" mouse wheel is too fast. A > multiplier is applied that maps the values used for > kCGScrollEventUnitLine to (effectively) kCGScrollEventUnitPixel, and the > one used for MacViews was too big. Share the constant that content:: > uses by moving it to ui/events/cocoa/cocoa_event_utils.h > > Add a test to ensure the event types agree. Problem: the initializers on > NSEvent for creating test events are too limited. We also want to beef > up testing of scroll event streams for elastic scrolling and whatnot, so > move the stuff in events_mac_unittest.mm to cocoa_test_event_utils:: for > creating test scroll events. > > BUG=615948 > > Committed: https://crrev.com/315a111b6cdd928cbd0862dd97f5a98482dd0261 > Cr-Commit-Position: refs/heads/master@{#411216} TBR=avi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615948 Committed: https://crrev.com/941118827f5240dedb40082cffb1ead6c6d621cc Cr-Commit-Position: refs/heads/master@{#411223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -138 lines) Patch
M content/browser/renderer_host/input/web_input_event_builders_mac.mm View 2 chunks +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm View 2 chunks +0 lines, -41 lines 0 comments Download
M ui/events/cocoa/cocoa_event_utils.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/cocoa/events_mac.mm View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/events/cocoa/events_mac_unittest.mm View 2 chunks +40 lines, -13 lines 0 comments Download
M ui/events/test/cocoa_test_event_utils.h View 2 chunks +0 lines, -19 lines 0 comments Download
M ui/events/test/cocoa_test_event_utils.mm View 2 chunks +0 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tapted
Created Revert of Mac: Share kScrollbarPixelsPerCocoaTick between ui:: and blink:: events
4 years, 4 months ago (2016-08-11 01:54:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234143003/1
4 years, 4 months ago (2016-08-11 01:55:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 01:56:27 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 01:58:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/941118827f5240dedb40082cffb1ead6c6d621cc
Cr-Commit-Position: refs/heads/master@{#411223}

Powered by Google App Engine
This is Rietveld 408576698