src/factory.cc - Issue 223413002: Partial recover from performance degradation after handlification of ElementsAccessor::CopyElements…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 223413002: Partial recover from performance degradation after handlification of ElementsAccessor::CopyElements… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 52a194180be30b9c675b83ef45d7ce06f137f45e..9fa1e12abe19253aad57c1e743863fd30ceac259 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1369,9 +1369,6 @@ Handle<JSArray> Factory::NewJSArray(ElementsKind elements_kind,

int capacity,

ArrayStorageAllocationMode mode,

PretenureFlag pretenure) {

- if (capacity != 0) {

- elements_kind = GetHoleyElementsKind(elements_kind);

- }

CALL_HEAP_FUNCTION(isolate(),

isolate()->heap()->AllocateJSArrayAndStorage(

elements_kind,

« no previous file with comments | « src/factory.h ('k') | no next file » | no next file with comments »