Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: src/objects.cc

Issue 223413002: Partial recover from performance degradation after handlification of ElementsAccessor::CopyElements… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/factory.h ('K') | « src/factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 9cda2baf0d44476c6aeef51b8deb600a5fe35395..38fd122fe016538d4191e6115cc0132df9e30a98 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -11193,7 +11193,7 @@ Handle<FixedArray> JSObject::SetFastElementsCapacityAndLength(
}
Handle<FixedArrayBase> old_elements(object->elements());
ElementsAccessor* accessor = ElementsAccessor::ForKind(new_elements_kind);
- accessor->CopyElements(object, new_elements, elements_kind);
+ accessor->CopyElements(*object, new_elements, elements_kind);
if (elements_kind != SLOPPY_ARGUMENTS_ELEMENTS) {
Handle<Map> new_map = (new_elements_kind != elements_kind)
@@ -11243,7 +11243,7 @@ void JSObject::SetFastDoubleElementsCapacityAndLength(Handle<JSObject> object,
Handle<FixedArrayBase> old_elements(object->elements());
ElementsAccessor* accessor = ElementsAccessor::ForKind(FAST_DOUBLE_ELEMENTS);
- accessor->CopyElements(object, elems, elements_kind);
+ accessor->CopyElements(*object, elems, elements_kind);
object->ValidateElements();
JSObject::SetMapAndElements(object, new_map, elems);
« src/factory.h ('K') | « src/factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698