Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java

Issue 2234123002: Fixed flaky CronetSampleTest#testLoadUrl test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java
diff --git a/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java b/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java
index 07661afc68b420898a34c67a73a35737f01c83e4..dbfd1473d3d22c6f4dcc17cbd1064c6497ea2596 100644
--- a/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java
+++ b/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java
@@ -12,7 +12,6 @@ import android.test.ActivityInstrumentationTestCase2;
import android.test.suitebuilder.annotation.SmallTest;
import android.text.Editable;
import android.text.TextWatcher;
-import android.util.Log;
import android.widget.TextView;
import org.chromium.base.test.util.Feature;
@@ -23,7 +22,6 @@ import org.chromium.net.test.EmbeddedTestServer;
*/
public class CronetSampleTest extends
ActivityInstrumentationTestCase2<CronetSampleActivity> {
- private static final String TAG = CronetSampleTest.class.getSimpleName();
private EmbeddedTestServer mTestServer;
private String mUrl;
@@ -65,22 +63,15 @@ public class CronetSampleTest extends
@Override
public void onTextChanged(CharSequence s, int start, int before, int count) {
- if (s.equals("Completed " + mUrl + " (200)")) {
+ if (s.toString().equals("Completed " + mUrl + " (200)")) {
done.open();
- } else {
- // TODO(xunjieli): remove this log once crbug.com/635021 is fixed.
- Log.e(CronetSampleTest.class.getSimpleName(), s.toString());
}
}
};
textView.addTextChangedListener(textWatcher);
// Check current text in case it changed before |textWatcher| was added.
textWatcher.onTextChanged(textView.getText(), 0, 0, 0);
- // TODO(xunjieli): remove this log once crbug.com/635021 is fixed.
- Log.e(TAG, "waiting for text change**********************");
done.block();
- // TODO(xunjieli): remove this log once crbug.com/635021 is fixed.
- Log.e(TAG, "received text change**********************");
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698