Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: components/cronet/android/BUILD.gn

Issue 2234113002: Include generated EffectiveConnectionType.java in cronet api jar and JavaDoc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ignore RequestFinishedListener.java Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/api/build.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index 8534e6bdba7503142dd88f1acea8094f5aa37bbf..99485b52af894a15928f64f36a3706c6e68f2de4 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -816,11 +816,22 @@ template("jar_src") {
"--depfile",
rebase_path(depfile, root_build_dir),
]
+
+ if (defined(invoker.src_jars)) {
+ _rebased_src_jars = rebase_path(invoker.src_jars, root_build_dir)
+ args += [ "--src-jar=${_rebased_src_jars}" ]
+ }
+ deps = [
+ ":effective_connection_type_java",
+ ]
}
}
jar_src("jar_cronet_api_source") {
src_dirs = [ "api/src" ]
+
+ # Include generated Java files which should be a part of the API.
+ src_jars = [ "$root_gen_dir/components/cronet/android/effective_connection_type_java.srcjar" ]
jar_path = "$_package_dir/cronet_api-src.jar"
}
@@ -872,9 +883,14 @@ action("generate_javadoc") {
"--lib-java-dir",
rebase_path("$root_build_dir/lib.java/components/cronet/android",
root_build_dir),
+
+ # JavaDoc is generated from Cronet's API source jar.
+ "--input-src-jar",
+ rebase_path("$_package_dir/cronet_api-src.jar", root_build_dir),
]
deps = [
":cronet_javadoc_classpath",
+ ":jar_cronet_api_source",
]
}
« no previous file with comments | « no previous file | components/cronet/android/api/build.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698