Issue 223403012: SkDiscardableMemoryPool to abstract class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223403012: SkDiscardableMemoryPool to abstract class (Closed)

Created:
6 years, 8 months ago by hal.canary

Modified:
6 years, 8 months ago

Reviewers:
scroggo, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

SkDiscardableMemoryPool to abstract class Motivation - we want to keep our public headers small. Committed: http://code.google.com/p/skia/source/detail?r=14063

Patch Set 1 #

Patch Set 2 : AnotherPatchSet #

Patch Set 3 : AnotherPatchSet #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -106 lines)			Patch
M	gm/factory.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
D	src/lazy/SkDiscardableMemoryPool.h	View	1 2	1 chunk	+32 lines, -42 lines	0 comments	Download
M	src/lazy/SkDiscardableMemoryPool.cpp	View	1 2	5 chunks	+116 lines, -49 lines	0 comments	Download
M	tests/CachedDecodingPixelRefTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/DiscardableMemoryPoolTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/DrawBitmapRectTest.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/ImageCacheTest.cpp	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/bench_pictures_main.cpp	View	1 2	4 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/223403012/60001

6 years, 8 months ago (2014-04-04 16:43:25 UTC) #4

scroggo

6 years, 8 months ago (2014-04-04 17:39:45 UTC) #6

Message was sent while issue was closed.

On 2014/04/04 16:43:42, I haz the power (commit-bot) wrote:
> Change committed as 14063

Patch set 3 doesn't help Android. We want to keep them from accessing files in
src/, so we need to provide some sort of API in include/.

Expand Messages | Collapse Messages