sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart - Issue 223403003: Use closure tracer to identify closures that are not passed to Function.apply

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart

Issue 223403003: Use closure tracer to identify closures that are not passed to Function.apply (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix regression in emitted meta data Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart ('K') | « sdk/lib/_internal/compiler/implementation/inferrer/map_tracer.dart ('k') | sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart » ('j') | sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart b/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart

index 73a81dc51fb9f636ac6b1b4bea8f8aa103489a80..afdf0d44fa36f7bb1fb97b2723e98f2492896cb0 100644

--- a/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart

+++ b/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart

@@ -63,8 +63,9 @@ Set<String> doesNotEscapeMapSet = new Set<String>.from(

'containsValue'

]);

-abstract class TracerVisitor implements TypeInformationVisitor {

- final TypeInformation tracedType;

+abstract class TracerVisitor<T extends TypeInformation>

+ implements TypeInformationVisitor {

+ final T tracedType;

final TypeGraphInferrerEngine inferrer;

final Compiler compiler;

@@ -292,7 +293,7 @@ abstract class TracerVisitor implements TypeInformationVisitor {

&& inferrer.isNativeElement(element.enclosingElement)) {

bailout('Passed to a native method');

}

- if (info.isClosurized()) {

+ if (info.isClosurized) {

bailout('Returned from a closurized method');

}

if (isClosure(info.element)) {