sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart - Issue 223403003: Use closure tracer to identify closures that are not passed to Function.apply

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

Issue 223403003: Use closure tracer to identify closures that are not passed to Function.apply (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fixed issue with failing test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart ('k') | sdk/lib/_internal/compiler/implementation/world.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

index 291f30e31cf84737a6533e6137301b18ae6b057d..8229874b8005a32b5650a777a1d1744a73498fae 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

@@ -355,8 +355,9 @@ class ContainerBuilder extends CodeEmitterHelper {

bool needsStubs = !parameters.optionalParameters.isEmpty;

bool canTearOff = false;

bool isClosure = false;

- bool isNotApplyTarget =

- !member.isFunction() || member.isConstructor() || member.isAccessor();

+ bool isNotApplyTarget = !member.isFunction() ||

+ member.isConstructor() ||

+ member.isAccessor();

String tearOffName;

if (isNotApplyTarget) {

canTearOff = false;

@@ -375,9 +376,9 @@ class ContainerBuilder extends CodeEmitterHelper {

compiler.codegenWorld.staticFunctionsNeedingGetter.contains(member);

tearOffName = namer.getStaticClosureName(member);

}

- final bool canBeApplied = !isNotApplyTarget &&

- compiler.enabledFunctionApply &&

- (canTearOff || member.name == 'call' || !member.isInstanceMember());

+ final bool canBeApplied = compiler.enabledFunctionApply &&

+ compiler.world.getMightBePassedToApply(member);

final bool canBeReflected = backend.isAccessibleByReflection(member);

final bool needStructuredInfo =

canTearOff || canBeReflected || canBeApplied;