Refactor WebInputEventAura to ui/events/blink

Refactor WebInputEventAura to ui/events/blink

Refactor the current ui::Event to blink::WebInputEvent converters from content/browser/renderer_host/ to ui/events/blink.

This is so we can merge mojo/converters/blink with this code, to have one unified location for all of the conversions.

TEST=content_unittests, events_unittests, manual testing
BUG=616673
Committed: https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe
Cr-Commit-Position: refs/heads/master@{#412942}

[jonross, 2016-08-10 18:51:43]

Description was changed from

==========
Refacotr WebInputEventAura to ui/events/blink

Refactor the current ui::Event to blink::WebInputEvent from
content/browser/renderer_host/ to ui/events/blink.

This is so we can merge mojo/converters/blink with this code, to have one
unified location for all of the conversions.

TEST=content_unittests, events_unittests, manual testing
BUG=616673
==========

to

==========
Refacotr WebInputEventAura to ui/events/blink

Refactor the current ui::Event to blink::WebInputEvent from
content/browser/renderer_host/ to ui/events/blink.

This is so we can merge mojo/converters/blink with this code, to have one
unified location for all of the conversions.

TEST=content_unittests, events_unittests, manual testing
BUG=616673
==========

[jonross, 2016-08-11 18:52:31]

jonross@chromium.org changed reviewers:
+ sadrul@chromium.org

[jonross, 2016-08-11 18:52:32]

Hey Sadrul,

Could you take a look at this first stage of refactoring all ui::Events ->
blink::WebInputEvents.

I am pulling out the code from content/browser/renderer_host/ into
ui/events/blink

Thanks,
Jon

[dtapuska, 2016-08-11 18:57:22]

dtapuska@chromium.org changed reviewers:
+ dtapuska@chromium.org

[dtapuska, 2016-08-11 18:57:23]

https://codereview.chromium.org/2234023002/diff/140001/ui/events/blink/web_in...
File ui/events/blink/web_input_event_builders_win.h (left):

https://codereview.chromium.org/2234023002/diff/140001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win.h:11: #include
"third_party/WebKit/public/web/WebInputEvent.h"
Please update the import paths from web to platform for WebInputEvent.h

[jonross, 2016-08-11 20:20:33]

https://codereview.chromium.org/2234023002/diff/140001/ui/events/blink/web_in...
File ui/events/blink/web_input_event_builders_win.h (left):

https://codereview.chromium.org/2234023002/diff/140001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win.h:11: #include
"third_party/WebKit/public/web/WebInputEvent.h"
On 2016/08/11 18:57:23, dtapuska wrote:
> Please update the import paths from web to platform for WebInputEvent.h

Done.

[jonross, 2016-08-12 13:37:12]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 13:37:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 13:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 13:53:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jonross, 2016-08-12 14:07:45]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 14:07:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 14:32:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 14:32:47]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[jonross, 2016-08-12 17:52:25]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 17:53:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 18:15:00]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[sadrul, 2016-08-15 15:25:53]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 15:26:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-15 15:55:13]

Mostly nits, but lgtm (please get a review from dtapuska@/tdresser@ too)

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
File ui/events/blink/web_input_event.cc (right):

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event.cc:28: return event.target() ?
screen_location_callback.Run(event)
DCHECK that screen_location_callback is non-null

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event.cc:92: blink::WebGestureEvent
MakeWebGestureEventFromNativeEvent(
We should just remove this (maybe in a follow up CL). We do not receive gesture
events from the platform on Windows.

I think we can get rid of some of the builders from blink, and instead use the
code here in events/blink. You shouldn't do that in this CL, but something to
keep in mind.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
File ui/events/blink/web_input_event.h (right):

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event.h:1: // Copyright (c) 2012 The Chromium Authors.
All rights reserved.
Update

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event.h:27: screen_location_callback);
Document the callback. Leave a TODO here that the callback would ideally be not
needed. Refer to crbug.com/608547

Also document that if a valid event can't be created, then the returned event
has type UNKNOWN

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event.h:49: #endif  //
CONTENT_BROWSER_RENDERER_HOST_WEB_INPUT_EVENT_AURA_H_
Update (tools/git/mass-rename.sh should normally auto-update this)

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
File ui/events/blink/web_input_event_builders_win.cc (right):

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win.cc:37: case WM_KEYDOWN:
Add a '// fallthrough' comment here.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win.cc:41: result.isSystemKey = true;
ditto

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win.cc:50: result.type =
WebInputEvent::Char;
Remove this, add a // fallthrough comment.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
File ui/events/blink/web_input_event_builders_win_unittest.cc (right):

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win_unittest.cc:23: #if defined(OS_WIN)
Remove the ifdefs from this file, and include this file only for win in BUILD.gn

[commit-bot: I haz the power, 2016-08-15 16:20:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 16:20:56]

Dry run: This issue passed the CQ dry run.

[tdresser, 2016-08-15 19:29:49]

tdresser@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2016-08-15 19:29:50]

"Refacotr WebInputEventAura to ui/events/blink"
Refactor

"Refactor the current ui::Event to blink::WebInputEvent"
Word missing perhaps?

[dtapuska, 2016-08-15 19:31:34]

On 2016/08/15 15:55:13, sadrul wrote:
> Mostly nits, but lgtm (please get a review from dtapuska@/tdresser@ too)
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> File ui/events/blink/web_input_event.cc (right):
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> ui/events/blink/web_input_event.cc:28: return event.target() ?
> screen_location_callback.Run(event)
> DCHECK that screen_location_callback is non-null
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> ui/events/blink/web_input_event.cc:92: blink::WebGestureEvent
> MakeWebGestureEventFromNativeEvent(
> We should just remove this (maybe in a follow up CL). We do not receive
gesture
> events from the platform on Windows.
> 
> I think we can get rid of some of the builders from blink, and instead use the
> code here in events/blink. You shouldn't do that in this CL, but something to
> keep in mind.
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> File ui/events/blink/web_input_event.h (right):
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> ui/events/blink/web_input_event.h:1: // Copyright (c) 2012 The Chromium
Authors.
> All rights reserved.
> Update
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> ui/events/blink/web_input_event.h:27: screen_location_callback);
> Document the callback. Leave a TODO here that the callback would ideally be
not
> needed. Refer to crbug.com/608547
> 
> Also document that if a valid event can't be created, then the returned event
> has type UNKNOWN
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> ui/events/blink/web_input_event.h:49: #endif  //
> CONTENT_BROWSER_RENDERER_HOST_WEB_INPUT_EVENT_AURA_H_
> Update (tools/git/mass-rename.sh should normally auto-update this)
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> File ui/events/blink/web_input_event_builders_win.cc (right):
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> ui/events/blink/web_input_event_builders_win.cc:37: case WM_KEYDOWN:
> Add a '// fallthrough' comment here.
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> ui/events/blink/web_input_event_builders_win.cc:41: result.isSystemKey = true;
> ditto
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> ui/events/blink/web_input_event_builders_win.cc:50: result.type =
> WebInputEvent::Char;
> Remove this, add a // fallthrough comment.
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> File ui/events/blink/web_input_event_builders_win_unittest.cc (right):
> 
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> ui/events/blink/web_input_event_builders_win_unittest.cc:23: #if
defined(OS_WIN)
> Remove the ifdefs from this file, and include this file only for win in
BUILD.gn

this seems fine to me; but I'm wondering why the mac events didn't move over. Is
the goal not to use more aura and views on mac?

[jonross, 2016-08-16 13:50:16]

On 2016/08/15 19:31:34, dtapuska wrote:
> On 2016/08/15 15:55:13, sadrul wrote:
> > Mostly nits, but lgtm (please get a review from dtapuska@/tdresser@ too)
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > File ui/events/blink/web_input_event.cc (right):
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > ui/events/blink/web_input_event.cc:28: return event.target() ?
> > screen_location_callback.Run(event)
> > DCHECK that screen_location_callback is non-null
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > ui/events/blink/web_input_event.cc:92: blink::WebGestureEvent
> > MakeWebGestureEventFromNativeEvent(
> > We should just remove this (maybe in a follow up CL). We do not receive
> gesture
> > events from the platform on Windows.
> > 
> > I think we can get rid of some of the builders from blink, and instead use
the
> > code here in events/blink. You shouldn't do that in this CL, but something
to
> > keep in mind.
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > File ui/events/blink/web_input_event.h (right):
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > ui/events/blink/web_input_event.h:1: // Copyright (c) 2012 The Chromium
> Authors.
> > All rights reserved.
> > Update
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > ui/events/blink/web_input_event.h:27: screen_location_callback);
> > Document the callback. Leave a TODO here that the callback would ideally be
> not
> > needed. Refer to crbug.com/608547
> > 
> > Also document that if a valid event can't be created, then the returned
event
> > has type UNKNOWN
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > ui/events/blink/web_input_event.h:49: #endif  //
> > CONTENT_BROWSER_RENDERER_HOST_WEB_INPUT_EVENT_AURA_H_
> > Update (tools/git/mass-rename.sh should normally auto-update this)
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > File ui/events/blink/web_input_event_builders_win.cc (right):
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > ui/events/blink/web_input_event_builders_win.cc:37: case WM_KEYDOWN:
> > Add a '// fallthrough' comment here.
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > ui/events/blink/web_input_event_builders_win.cc:41: result.isSystemKey =
true;
> > ditto
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > ui/events/blink/web_input_event_builders_win.cc:50: result.type =
> > WebInputEvent::Char;
> > Remove this, add a // fallthrough comment.
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > File ui/events/blink/web_input_event_builders_win_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
> > ui/events/blink/web_input_event_builders_win_unittest.cc:23: #if
> defined(OS_WIN)
> > Remove the ifdefs from this file, and include this file only for win in
> BUILD.gn
> 
> this seems fine to me; but I'm wondering why the mac events didn't move over.
Is
> the goal not to use more aura and views on mac?

I'm not aware of the current plans around the use of aura on mac. For
web_input_event_builders_mac* since they transition from NSEvent to
blink::WebInputEvent it seemed outside the scope of this initial refactor. I'm
looking at merging the 3 different ways we convert from ui::Event to
blink::WebInputEvent.

However I can see how moving the mac event conversion to ui/events/blink would
also make sense as a standalone refactor.

[sadrul, 2016-08-16 14:36:21]

> > this seems fine to me; but I'm wondering why the mac events didn't move
over.
> Is
> > the goal not to use more aura and views on mac?
> 
> I'm not aware of the current plans around the use of aura on mac. For
> web_input_event_builders_mac* since they transition from NSEvent to
> blink::WebInputEvent it seemed outside the scope of this initial refactor. I'm
> looking at merging the 3 different ways we convert from ui::Event to
> blink::WebInputEvent.
> 
> However I can see how moving the mac event conversion to ui/events/blink would
> also make sense as a standalone refactor.

Yes, mac doesn't use ui::Event, and instead directly creates an NSEvent into a
WebInputEvent. There are also NSEvent -> ui::Event converters that I believe the
views parts in mac use. Not sure if there are plans to unify a bit with other
platforms, and have the event go through a ui::Event conversion step for mac.
The mac-views folks (e.g. tapted@) would know.

[jonross, 2016-08-16 15:05:51]

Description was changed from

==========
Refacotr WebInputEventAura to ui/events/blink

Refactor the current ui::Event to blink::WebInputEvent from
content/browser/renderer_host/ to ui/events/blink.

This is so we can merge mojo/converters/blink with this code, to have one
unified location for all of the conversions.

TEST=content_unittests, events_unittests, manual testing
BUG=616673
==========

to

==========
Refactor WebInputEventAura to ui/events/blink

Refactor the current ui::Event to blink::WebInputEvent converters from
content/browser/renderer_host/ to ui/events/blink.

This is so we can merge mojo/converters/blink with this code, to have one
unified location for all of the conversions.

TEST=content_unittests, events_unittests, manual testing
BUG=616673
==========

[jonross, 2016-08-16 15:25:16]

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
File ui/events/blink/web_input_event.cc (right):

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event.cc:28: return event.target() ?
screen_location_callback.Run(event)
On 2016/08/15 15:55:12, sadrul wrote:
> DCHECK that screen_location_callback is non-null

Done.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event.cc:92: blink::WebGestureEvent
MakeWebGestureEventFromNativeEvent(
On 2016/08/15 15:55:12, sadrul wrote:
> We should just remove this (maybe in a follow up CL). We do not receive
gesture
> events from the platform on Windows.
> 
> I think we can get rid of some of the builders from blink, and instead use the
> code here in events/blink. You shouldn't do that in this CL, but something to
> keep in mind.

I've noted this on the bug.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
File ui/events/blink/web_input_event.h (right):

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event.h:1: // Copyright (c) 2012 The Chromium Authors.
All rights reserved.
On 2016/08/15 15:55:13, sadrul wrote:
> Update

Done.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event.h:27: screen_location_callback);
On 2016/08/15 15:55:12, sadrul wrote:
> Document the callback. Leave a TODO here that the callback would ideally be
not
> needed. Refer to crbug.com/608547
> 
> Also document that if a valid event can't be created, then the returned event
> has type UNKNOWN

Done.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event.h:49: #endif  //
CONTENT_BROWSER_RENDERER_HOST_WEB_INPUT_EVENT_AURA_H_
On 2016/08/15 15:55:12, sadrul wrote:
> Update (tools/git/mass-rename.sh should normally auto-update this)

Done.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
File ui/events/blink/web_input_event_builders_win.cc (right):

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win.cc:37: case WM_KEYDOWN:
On 2016/08/15 15:55:13, sadrul wrote:
> Add a '// fallthrough' comment here.

Done.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win.cc:41: result.isSystemKey = true;
On 2016/08/15 15:55:13, sadrul wrote:
> ditto

Done.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win.cc:50: result.type =
WebInputEvent::Char;
On 2016/08/15 15:55:13, sadrul wrote:
> Remove this, add a // fallthrough comment.

Done.

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
File ui/events/blink/web_input_event_builders_win_unittest.cc (right):

https://codereview.chromium.org/2234023002/diff/220001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win_unittest.cc:23: #if defined(OS_WIN)
On 2016/08/15 15:55:13, sadrul wrote:
> Remove the ifdefs from this file, and include this file only for win in
BUILD.gn

Done.

[jonross, 2016-08-16 17:41:10]

On 2016/08/15 19:29:50, tdresser wrote:
> "Refacotr WebInputEventAura to ui/events/blink"
> Refactor
> 
> "Refactor the current ui::Event to blink::WebInputEvent"
> Word missing perhaps?

Updated the description. We are refactoring out the converters.

[jonross, 2016-08-16 22:18:06]

On 2016/08/16 17:41:10, jonross wrote:
> On 2016/08/15 19:29:50, tdresser wrote:
> > "Refacotr WebInputEventAura to ui/events/blink"
> > Refactor
> > 
> > "Refactor the current ui::Event to blink::WebInputEvent"
> > Word missing perhaps?
> 
> Updated the description. We are refactoring out the converters.

dtapuska@, tdresser@ any other thoughts?

[dtapuska, 2016-08-17 00:29:49]

On 2016/08/16 22:18:06, jonross wrote:
> On 2016/08/16 17:41:10, jonross wrote:
> > On 2016/08/15 19:29:50, tdresser wrote:
> > > "Refacotr WebInputEventAura to ui/events/blink"
> > > Refactor
> > > 
> > > "Refactor the current ui::Event to blink::WebInputEvent"
> > > Word missing perhaps?
> > 
> > Updated the description. We are refactoring out the converters.
> 
> dtapuska@, tdresser@ any other thoughts?

Lgtm

[tdresser, 2016-08-17 11:56:24]

On 2016/08/17 00:29:49, dtapuska wrote:
> On 2016/08/16 22:18:06, jonross wrote:
> > On 2016/08/16 17:41:10, jonross wrote:
> > > On 2016/08/15 19:29:50, tdresser wrote:
> > > > "Refacotr WebInputEventAura to ui/events/blink"
> > > > Refactor
> > > > 
> > > > "Refactor the current ui::Event to blink::WebInputEvent"
> > > > Word missing perhaps?
> > > 
> > > Updated the description. We are refactoring out the converters.
> > 
> > dtapuska@, tdresser@ any other thoughts?
> 
> Lgtm

LGTM.

[jonross, 2016-08-17 13:27:52]

avi@ would you be able to provide an owner's review of:

content/browser/BUILD.gn
content/browser/android/content_view_core_impl.cc
content/test/BUILD.gn

This refactor is moving code from content/browser/renderer_host to
ui/events/blink

Thanks,
Jon

[jonross, 2016-08-17 13:28:46]

jonross@chromium.org changed reviewers:
+ avi@chromium.org

[jonross, 2016-08-17 13:28:46]

avi@ would you be able to provide an owner's review of:

content/browser/BUILD.gn
content/browser/android/content_view_core_impl.cc
content/test/BUILD.gn

This refactor is moving code from content/browser/renderer_host to
ui/events/blink

Thanks,
Jon

[Avi (use Gerrit), 2016-08-17 14:43:21]

On 2016/08/17 13:28:46, jonross wrote:
> avi@ would you be able to provide an owner's review of:
> 
> content/browser/BUILD.gn
> content/browser/android/content_view_core_impl.cc
> content/test/BUILD.gn
> 
> This refactor is moving code from content/browser/renderer_host to
> ui/events/blink
> 
> Thanks,
> Jon

Those files LGTM

[jonross, 2016-08-17 14:45:02]

The CQ bit was checked by jonross@chromium.org

[jonross, 2016-08-17 14:45:03]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2234023002/#ps260001
(title: "Address Review Comments")

[commit-bot: I haz the power, 2016-08-17 14:45:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 14:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 14:47:44]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jonross, 2016-08-17 15:54:55]

The CQ bit was checked by jonross@chromium.org

[jonross, 2016-08-17 15:54:55]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
avi@chromium.org, dtapuska@chromium.org, tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2234023002/#ps280001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-17 15:55:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 16:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 16:02:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jonross, 2016-08-17 17:01:53]

jonross@chromium.org changed reviewers:
+ dglazkov@chromium.org

[jonross, 2016-08-17 17:03:28]

On 2016/08/17 16:02:40, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Hi dglazkov@,

In this review we are switching the DEPS in ui/events/blink from
third_party/WebKit/public/web/WebInputEvent.h to
third_party/WebKit/public/platform/WebInputEvent.h as dtapuska@ mentioned the
goal of switching to this.

Could you provide an owners review of this DEPS change?

Thanks

[dglazkov, 2016-08-18 17:31:48]

lgtm

[jonross, 2016-08-18 17:34:29]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-08-18 17:34:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 17:38:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 17:38:03]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jonross, 2016-08-18 18:25:35]

The CQ bit was checked by jonross@chromium.org

[jonross, 2016-08-18 18:25:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org, avi@chromium.org, sadrul@chromium.org,
dglazkov@chromium.org, tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2234023002/#ps300001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-18 18:25:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 19:51:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 19:51:52]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jonross, 2016-08-18 20:16:46]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:17:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 21:49:18]

Description was changed from

==========
Refactor WebInputEventAura to ui/events/blink

Refactor the current ui::Event to blink::WebInputEvent converters from
content/browser/renderer_host/ to ui/events/blink.

This is so we can merge mojo/converters/blink with this code, to have one
unified location for all of the conversions.

TEST=content_unittests, events_unittests, manual testing
BUG=616673
==========

to

==========
Refactor WebInputEventAura to ui/events/blink

Refactor the current ui::Event to blink::WebInputEvent converters from
content/browser/renderer_host/ to ui/events/blink.

This is so we can merge mojo/converters/blink with this code, to have one
unified location for all of the conversions.

TEST=content_unittests, events_unittests, manual testing
BUG=616673
==========

[commit-bot: I haz the power, 2016-08-18 21:49:20]

Committed patchset #16 (id:300001)

[commit-bot: I haz the power, 2016-08-18 21:54:07]

Description was changed from

==========
Refactor WebInputEventAura to ui/events/blink

Refactor the current ui::Event to blink::WebInputEvent converters from
content/browser/renderer_host/ to ui/events/blink.

This is so we can merge mojo/converters/blink with this code, to have one
unified location for all of the conversions.

TEST=content_unittests, events_unittests, manual testing
BUG=616673
==========

to

==========
Refactor WebInputEventAura to ui/events/blink

Refactor the current ui::Event to blink::WebInputEvent converters from
content/browser/renderer_host/ to ui/events/blink.

This is so we can merge mojo/converters/blink with this code, to have one
unified location for all of the conversions.

TEST=content_unittests, events_unittests, manual testing
BUG=616673

Committed: https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe
Cr-Commit-Position: refs/heads/master@{#412942}
==========

[commit-bot: I haz the power, 2016-08-18 21:54:08]

Patchset 16 (id:??) landed as
https://crrev.com/2addcb7b7dafe269307a85a7f99b4da6cd2907fe
Cr-Commit-Position: refs/heads/master@{#412942}