Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2233993002:
Remove TRACE_EVENT_FLAG_COPY in runtime call stats tracing. (Closed)
DescriptionRemove TRACE_EVENT_FLAG_COPY in runtime call stats tracing.
By removing the copy flag, we reduce the amount of strings to be copied each
time.
BUG=v8:5089
LOG=N
Committed: https://crrev.com/1131096417b6477ee6fc610acc41f94030385733
Cr-Commit-Position: refs/heads/master@{#38955}
Patch Set 1 #Patch Set 2 : update #Messages
Total messages: 21 (13 generated)
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lpy@chromium.org changed reviewers: + cbruni@chromium.org, fmeawad@chromium.org
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gentle ping for review.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
adamk@chromium.org changed reviewers: + adamk@chromium.org
lgtm
The CQ bit was checked by lpy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fmeawad@chromium.org Link to the patchset: https://codereview.chromium.org/2233993002/#ps20001 (title: "update")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove TRACE_EVENT_FLAG_COPY in runtime call stats tracing. By removing the copy flag, we reduce the amount of strings to be copied each time. BUG=v8:5089 LOG=N ========== to ========== Remove TRACE_EVENT_FLAG_COPY in runtime call stats tracing. By removing the copy flag, we reduce the amount of strings to be copied each time. BUG=v8:5089 LOG=N Committed: https://crrev.com/1131096417b6477ee6fc610acc41f94030385733 Cr-Commit-Position: refs/heads/master@{#38955} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1131096417b6477ee6fc610acc41f94030385733 Cr-Commit-Position: refs/heads/master@{#38955}
Message was sent while issue was closed.
lgtm |
