Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2233983003: Add better bounds checks for getTime to fix perf debug assert below (Closed)

Created:
4 years, 4 months ago by Harry Stern
Modified:
4 years, 4 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add better bounds checks for getTime to fix perf debug assert below Due to rounding, we request a length slightly larger than the total length in MeasureBench. This will be fixed in a following CL and there will be another CL adding unit tests for bounds checking and other problems. Revert "Revert 386ba54 and 4ab47e0 : perf debug assert." This reverts commit 69aaa5a49a10454d573cbd8c5d980029d78ae459. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233983003 Committed: https://skia.googlesource.com/skia/+/5a4b18c6f27fb010954e6435ddf22b85a3b84b94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -65 lines) Patch
M src/utils/SkCurveMeasure.h View 2 chunks +9 lines, -7 lines 0 comments Download
M src/utils/SkCurveMeasure.cpp View 12 chunks +82 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Harry Stern
I thought I had tested on Debug but I guess not. I was doing something ...
4 years, 4 months ago (2016-08-10 19:09:25 UTC) #3
reed1
lgtm
4 years, 4 months ago (2016-08-10 19:17:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233983003/1
4 years, 4 months ago (2016-08-10 19:54:22 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 23:31:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5a4b18c6f27fb010954e6435ddf22b85a3b84b94

Powered by Google App Engine
This is Rietveld 408576698